You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2020/01/03 00:59:31 UTC
[GitHub] [tomee] Daniel-Dos opened a new pull request #626:
TOMEE-2759-Update-Eclipse-Krazo
Daniel-Dos opened a new pull request #626: TOMEE-2759-Update-Eclipse-Krazo
URL: https://github.com/apache/tomee/pull/626
Link to Jira = https://issues.apache.org/jira/browse/TOMEE-2759
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] emecas commented on issue #626:
TOMEE-2759-Update-Eclipse-Krazo
Posted by GitBox <gi...@apache.org>.
emecas commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo
URL: https://github.com/apache/tomee/pull/626#issuecomment-591094503
This could be a little off-topic [or not :)]
Since this upgrade only applied for those 3 examples, is there a way to include a check to validate the tests for each example are still passing , or is something like that already on place? or even covered and implicit to the general build?
Should not be the process for upgrading dependencies a more rigorous process ? at least from the point of view of documenting, or letting know what is the specific benefit of doing it, or why it is important, or by the simple fact of checking and ensure full backward compatibility.
Also it could be part of the description of the Dependency upgrade JIRA issue?
By the way there is already a new release after the one included in this PR.
https://github.com/eclipse-ee4j/krazo/releases/tag/1.1.0-M1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] emecas edited a comment on issue #626:
TOMEE-2759-Update-Eclipse-Krazo
Posted by GitBox <gi...@apache.org>.
emecas edited a comment on issue #626: TOMEE-2759-Update-Eclipse-Krazo
URL: https://github.com/apache/tomee/pull/626#issuecomment-591094503
@cesarhernandezgt @Daniel-Dos
This could be a little off-topic [or not :)]
Since this upgrade only applied for those 3 examples, is there a way to include a check to validate the tests for each example are still passing , or is something like that already on place? or even covered and implicit to the general build?
Should not be the process for upgrading dependencies a more rigorous process ? at least from the point of view of documenting, or letting know what is the specific benefit of doing it, or why it is important, or by the simple fact of checking and ensure full backward compatibility.
Also it could be part of the description of the Dependency upgrade JIRA issue?
By the way there is already a new release after the one included in this PR.
https://github.com/eclipse-ee4j/krazo/releases/tag/1.1.0-M1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] Daniel-Dos commented on issue #626:
TOMEE-2759-Update-Eclipse-Krazo
Posted by GitBox <gi...@apache.org>.
Daniel-Dos commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo
URL: https://github.com/apache/tomee/pull/626#issuecomment-570545029
thanks @cesarhernandezgt
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] cesarhernandezgt commented on issue #626:
TOMEE-2759-Update-Eclipse-Krazo
Posted by GitBox <gi...@apache.org>.
cesarhernandezgt commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo
URL: https://github.com/apache/tomee/pull/626#issuecomment-591124534
> Since this upgrade only applied for those 3 examples, is there a way to include a check to validate the tests for each example are still passing, or is something like that already on place? or even covered and implicit to the general build?
Currently, if at least one example fails on either compilation, test or build, the entire TomEE build fails since `examples` is a maven submodule.
> Should not be the process for upgrading dependencies a more rigorous process ? at least from the point of view of documenting, or letting know what is the specific benefit of doing it, or why it is important, or by the simple fact of checking and ensure full backward compatibility.
>
> Also it could be part of the description of the Dependency upgrade JIRA issue?
Good observation. Usually, I have seen the other approach: An issue who's bug gets resolved by a dependency update. But I agree that in both cases the context of the dependency upgrade should be reflected on the Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] cesarhernandezgt commented on issue #626:
TOMEE-2759-Update-Eclipse-Krazo
Posted by GitBox <gi...@apache.org>.
cesarhernandezgt commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo
URL: https://github.com/apache/tomee/pull/626#issuecomment-590915470
Hi @Daniel-Dos
I couldn't merge the PR since it seems there is a small conflict.
I'm happy to review again after that gets fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] Daniel-Dos commented on issue #626:
TOMEE-2759-Update-Eclipse-Krazo
Posted by GitBox <gi...@apache.org>.
Daniel-Dos commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo
URL: https://github.com/apache/tomee/pull/626#issuecomment-591724159
@cesarhernandezgt ,
I'm going to close this PR and open another one, because there was a problem in the conflict merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] jgallimore merged pull request #626:
TOMEE-2759-Update-Eclipse-Krazo
Posted by GitBox <gi...@apache.org>.
jgallimore merged pull request #626: TOMEE-2759-Update-Eclipse-Krazo
URL: https://github.com/apache/tomee/pull/626
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] Daniel-Dos removed a comment on issue #626:
TOMEE-2759-Update-Eclipse-Krazo
Posted by GitBox <gi...@apache.org>.
Daniel-Dos removed a comment on issue #626: TOMEE-2759-Update-Eclipse-Krazo
URL: https://github.com/apache/tomee/pull/626#issuecomment-591724159
@cesarhernandezgt ,
I'm going to close this PR and open another one, because there was a problem in the conflict merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services