You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by da...@apache.org on 2022/07/15 12:39:55 UTC
[doris] branch master updated: [Bug](vec compaction) fix compaction core with sequence column (#10845)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 06ecf8bdc5 [Bug](vec compaction) fix compaction core with sequence column (#10845)
06ecf8bdc5 is described below
commit 06ecf8bdc54cee36e48b2ead0bdfd7b9a502db0b
Author: yixiutt <10...@users.noreply.github.com>
AuthorDate: Fri Jul 15 20:39:50 2022 +0800
[Bug](vec compaction) fix compaction core with sequence column (#10845)
Block reader ignores sequence column but rowset writer should write this column, will core in set_source_column row_num DCHECK.
Sequence column works across rowsets, so compaction can not discard it and should keeps it altime.
Co-authored-by: yixiutt <yi...@selectdb.com>
---
be/src/vec/olap/block_reader.cpp | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/be/src/vec/olap/block_reader.cpp b/be/src/vec/olap/block_reader.cpp
index ab187367f9..abef78014b 100644
--- a/be/src/vec/olap/block_reader.cpp
+++ b/be/src/vec/olap/block_reader.cpp
@@ -106,8 +106,14 @@ void BlockReader::_init_agg_state(const ReaderParams& read_params) {
Status BlockReader::init(const ReaderParams& read_params) {
TabletReader::init(read_params);
- auto return_column_size =
- read_params.origin_return_columns->size() - (_sequence_col_idx != -1 ? 1 : 0);
+ int32_t return_column_size = 0;
+ // read sequence column if not reader_query
+ if (read_params.reader_type != ReaderType::READER_QUERY) {
+ return_column_size = read_params.origin_return_columns->size();
+ } else {
+ return_column_size =
+ read_params.origin_return_columns->size() - (_sequence_col_idx != -1 ? 1 : 0);
+ }
_return_columns_loc.resize(read_params.return_columns.size());
for (int i = 0; i < return_column_size; ++i) {
auto cid = read_params.origin_return_columns->at(i);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org