Re: Review Request 40754: Fixed flaky test (AvailableResourcesAfterRescinding).

[Alexander Rukletsov <ru...@gmail.com>]

> On Nov. 27, 2015, 10:28 p.m., Joris Van Remoortere wrote:
> > src/tests/master_quota_tests.cpp, line 964
> > <https://reviews.apache.org/r/40754/diff/1/?file=1147690#file1147690line964>
> >
> >     Can we settle, and then resume here?
> >     I think with Joseph's cleanups we shouldn't exit a test with the clock paused.

I think `Clock::resume()` here can be problematic, since it introduces the chance a batch allocation happens before the `Shutdown()`.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40754/#review108247
-----------------------------------------------------------


On Nov. 26, 2015, 5:34 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40754/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 5:34 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed flaky test (AvailableResourcesAfterRescinding).
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 15edb27f3ea5d3813c937614aa217ca999fd2481 
> 
> Diff: https://reviews.apache.org/r/40754/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000 with `allocation_interval` set to 1ms
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>