You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2010/05/26 01:13:32 UTC

[jira] Created: (HADOOP-6786) test-patch needs to verify Herriot integrity

test-patch needs to verify Herriot integrity
--------------------------------------------

                 Key: HADOOP-6786
                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
             Project: Hadoop Common
          Issue Type: Improvement
          Components: build
    Affects Versions: 0.21.0
            Reporter: Konstantin Boudnik


Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

    Attachment: HADOOP-6786.patch

The patch introduces new check which makes sure that system test framework bindings aren't broken by running {{inject-system-faults}} target. This is a simple compilation + aspect weaving and doesn't execute any additional tests.

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900832#action_12900832 ] 

Konstantin Boudnik commented on HADOOP-6786:
--------------------------------------------

Hudson seems to be not at his best for the last a couple of weeks. I have ran {{test-patch.sh}} on my dev. machine.
{noformat}
-1 overall.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 4 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.
{noformat}

The javadoc warning is apparently not connected to the patch itself. The only warnings I can see are in security related classes.


> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895907#action_12895907 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-6786:
------------------------------------------------

I may have missed something:
- In the code below, why setting PreTestTarget to a empty string?
{code}
+  PreTestTarget=""
+
+  echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME $PreTestTarget inject-system-faults"
+  $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME $PreTestTarget inject-system-faults
{code}
- The inject-system-faults target is not found in build.xml.  Where is it defined?

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896046#action_12896046 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-6786:
------------------------------------------------

I think we need
{code}
  (( RESULT = RESULT + $? ))
{code}
after calling checkInjectSystemFaults.

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926140#action_12926140 ] 

Hudson commented on HADOOP-6786:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/])
    

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.1
>
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904190#action_12904190 ] 

Hudson commented on HADOOP-6786:
--------------------------------

Integrated in Hadoop-Common-trunk #438 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/438/])
    HADOOP-6786. test-patch needs to verify Herriot integrity. Contributed by Konstantin Boudnik


> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.1
>
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894717#action_12894717 ] 

Konstantin Boudnik commented on HADOOP-6786:
--------------------------------------------

bq. all the patch test builds run on ubuntu machines and kill cmd seem to reside in /bin/kill 
I wonder how it works in two other places (for core and contrib tests) then?

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

           Status: Patch Available  (was: Open)
    Fix Version/s: 0.21.0

The patch can be verified in Common because Herriot framework is already integrated here.
Also, I have ran the new version of {{test-patch.sh}} locally and I can see that the required target is being invoked and new check's result is printed at the end of the process:
{noformat}
    +1 system tests framework.  The patch passed system tests framework compile.
{noformat}

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900834#action_12900834 ] 

Konstantin Boudnik commented on HADOOP-6786:
--------------------------------------------

I'll be committing this by end of today or Monday if there's no objections.

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

    Status: Open  (was: Patch Available)

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

I have committed this to 0.21 and trunk.

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890807#action_12890807 ] 

Konstantin Boudnik commented on HADOOP-6786:
--------------------------------------------

A review, please? All blockers were resolved.

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

    Attachment: HADOOP-6786.patch

{{PreTestTarget}} is a garbage I have missed out. Removed.
The target {{inject-system-faults}} is defined in src/test/aop/build/aop.xml

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

    Status: Patch Available  (was: Open)

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896981#action_12896981 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-6786:
------------------------------------------------

+1 the new patch looks good.

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872059#action_12872059 ] 

Hadoop QA commented on HADOOP-6786:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12445609/HADOOP-6786.patch
  against trunk revision 948573.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 4 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/549/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/549/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/549/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/549/console

This message is automatically generated.

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

    Status: Open  (was: Patch Available)

No luck with Hudson. :(

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

          Status: Patch Available  (was: Open)
    Hadoop Flags: [Reviewed]

Hudson doesn't pick it up :( even after the queue has been cleaned... One more

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik reassigned HADOOP-6786:
------------------------------------------

    Assignee: Konstantin Boudnik

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871415#action_12871415 ] 

Konstantin Boudnik commented on HADOOP-6786:
--------------------------------------------

To achieve this test-patch needs to execute one more ant target {{inject-system-faults}} which will perform aspects weaving and will guarantee that changes in the source code doesn't brake the integrity of the test code.

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

    Attachment: HADOOP-6786.patch

Thanks for catching it up, Nicholas. (note to self: there's no 'simple' patches, damn it). Attaching new version and re-submitting the patch.

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

    Status: Open  (was: Patch Available)

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

    Status: Open  (was: Patch Available)

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894642#action_12894642 ] 

Giridharan Kesavan commented on HADOOP-6786:
--------------------------------------------

{quote}
+  $PS auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
{quote}

all the patch test builds run on ubuntu machines and kill cmd seem to reside in /bin/kill 


> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

    Status: Patch Available  (was: Open)

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

    Status: Patch Available  (was: Open)

Seems to be stuck. resubmitting

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904069#action_12904069 ] 

Hudson commented on HADOOP-6786:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #377 (See [https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/377/])
    HADOOP-6786. test-patch needs to verify Herriot integrity. Contributed by Konstantin Boudnik


> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.1
>
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904065#action_12904065 ] 

Hudson commented on HADOOP-6786:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #368 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/368/])
    HADOOP-6786. test-patch needs to verify Herriot integrity. Contributed by Konstantin Boudnik


> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.1
>
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6786) test-patch needs to verify Herriot integrity

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6786:
---------------------------------------

    Fix Version/s: 0.21.1

> test-patch needs to verify Herriot integrity
> --------------------------------------------
>
>                 Key: HADOOP-6786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6786
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.1
>
>         Attachments: HADOOP-6786.patch, HADOOP-6786.patch, HADOOP-6786.patch
>
>
> Whenever a new patch is submitted for verification {{test-patch}} process has to make sure that none of Herriot bindings were broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.