You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/19 03:27:49 UTC

[GitHub] [kafka] showuon opened a new pull request #10722: MINOR: update java doc for deprecated methods

showuon opened a new pull request #10722:
URL: https://github.com/apache/kafka/pull/10722


   Update deprecated methods: 
   1. `KStream#through(String, Produced)`
   2. `KafkaConsumer#poll(long)`
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax merged pull request #10722: MINOR: update java doc for deprecated methods

Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #10722:
URL: https://github.com/apache/kafka/pull/10722


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #10722: MINOR: update java doc for deprecated methods

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #10722:
URL: https://github.com/apache/kafka/pull/10722#issuecomment-846673350


   Thanks for the PR @showuon! Merged to `trunk`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a change in pull request #10722: MINOR: update java doc for deprecated methods

Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10722:
URL: https://github.com/apache/kafka/pull/10722#discussion_r637474843



##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/Produced.java
##########
@@ -26,7 +26,11 @@
 
 /**
  * This class is used to provide the optional parameters when producing to new topics
- * using {@link KStream#through(String, Produced)} or {@link KStream#to(String, Produced)}.
+ * using {@link KStream#to(String, Produced)}.
+ *
+ * <p>
+ * Note: {@link KStream#through(String, Produced)} is deprecated, please use {@link KStream#repartition(Repartitioned)} instead

Review comment:
       Updated. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on a change in pull request #10722: MINOR: update java doc for deprecated methods

Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #10722:
URL: https://github.com/apache/kafka/pull/10722#discussion_r637451696



##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/Produced.java
##########
@@ -26,7 +26,11 @@
 
 /**
  * This class is used to provide the optional parameters when producing to new topics
- * using {@link KStream#through(String, Produced)} or {@link KStream#to(String, Produced)}.
+ * using {@link KStream#to(String, Produced)}.
+ *
+ * <p>
+ * Note: {@link KStream#through(String, Produced)} is deprecated, please use {@link KStream#repartition(Repartitioned)} instead

Review comment:
       I think we don't need this one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #10722: MINOR: update java doc for deprecated methods

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10722:
URL: https://github.com/apache/kafka/pull/10722#issuecomment-846490355


   @mjsax , thanks for the comment. I've updated, please take a look again. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #10722: MINOR: update java doc for deprecated methods

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10722:
URL: https://github.com/apache/kafka/pull/10722#issuecomment-843715792


   @mjsax , could you please review this small PR to update java doc? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org