You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/09/13 05:27:17 UTC
[GitHub] [incubator-uniffle] zuston opened a new pull request, #213: Fast fail when reading failed in ComposedClientReadHandler
zuston opened a new pull request, #213:
URL: https://github.com/apache/incubator-uniffle/pull/213
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Fast fail when reading failed in ComposedClientReadHandler
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
It should fast fail on network failure when reading shuffle data from memory/localfile/hdfs in `ComposedClientReadHandler`. If not, it will throw inconsistent blockIds and make users confused.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
UTs.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#issuecomment-1246201150
Ping @frankliee Could help review this PR? If OK, I think I will go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] frankliee commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
frankliee commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r971501022
##########
integration-test/common/src/test/java/org/apache/uniffle/test/QuorumTest.java:
##########
@@ -573,7 +574,12 @@ public void case7() throws Exception {
testAppId, 0, 0, 100, 1,
10, 1000, "", blockIdBitmap, taskIdBitmap,
Lists.newArrayList(shuffleServerInfo2), null, new DefaultIdHelper());
- assertTrue(readClient.readShuffleBlockData() == null);
+ try {
+ readClient.readShuffleBlockData();
+ fail();
+ } catch (RssException e) {
+ // ignore
Review Comment:
Could you add some log in catch {} to help diagnose when tests are broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#issuecomment-1249091806
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/213?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#213](https://codecov.io/gh/apache/incubator-uniffle/pull/213?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b112e2) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/9ef48d6bc7891a3866fbd95ce5f2d8ffd0ae2f25?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ef48d6) will **decrease** coverage by `0.06%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #213 +/- ##
============================================
- Coverage 59.10% 59.04% -0.07%
Complexity 1326 1326
============================================
Files 160 161 +1
Lines 8727 8736 +9
Branches 817 817
============================================
Hits 5158 5158
- Misses 3303 3312 +9
Partials 266 266
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...niffle/common/exception/FileNotFoundException.java](https://codecov.io/gh/apache/incubator-uniffle/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9leGNlcHRpb24vRmlsZU5vdEZvdW5kRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pache/uniffle/server/ShuffleServerGrpcService.java](https://codecov.io/gh/apache/incubator-uniffle/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyR3JwY1NlcnZpY2UuamF2YQ==) | `0.90% <0.00%> (-0.02%)` | :arrow_down: |
| [...torage/handler/impl/ComposedClientReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9Db21wb3NlZENsaWVudFJlYWRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...orage/handler/impl/LocalFileServerReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9Mb2NhbEZpbGVTZXJ2ZXJSZWFkSGFuZGxlci5qYXZh) | `77.96% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r978214104
##########
common/src/main/java/org/apache/uniffle/common/exception/FileNotFoundException.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.uniffle.common.exception;
+
+public class FileNotFoundException extends RuntimeException {
Review Comment:
`Java.io.FileNotFoundException` is IOException which need to catch in invoking side, so introduce this extending the `RuntimeException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#issuecomment-1251803298
PTAL @frankliee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r980690336
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/ComposedClientReadHandler.java:
##########
@@ -127,7 +127,7 @@ public ShuffleDataResult readShuffleData() {
return null;
}
} catch (Exception e) {
- LOG.error("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
+ throw new RssException("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
Review Comment:
But if you read data from memory, and this data is writing to the localfile, the data is incomplete, when we read the incomplete data, it will throw an exception. The exception prevent us reading the data from HDFS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#issuecomment-1249108950
Ping @frankliee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r979756337
##########
common/src/main/java/org/apache/uniffle/common/exception/FileNotFoundException.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.uniffle.common.exception;
+
+public class FileNotFoundException extends RuntimeException {
Review Comment:
What do u think @frankliee
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -533,6 +534,12 @@ public void getLocalShuffleIndex(GetLocalShuffleIndexRequest request,
builder.setIndexData(UnsafeByteOperations.unsafeWrap(data));
reply = builder.build();
+ } catch (FileNotFoundException indexFileNotFoundException) {
+ LOG.warn("Errors on getting localstorage index file for {}, maybe the data has been flushed to cold storage.",
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] frankliee commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
frankliee commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r971501022
##########
integration-test/common/src/test/java/org/apache/uniffle/test/QuorumTest.java:
##########
@@ -573,7 +574,12 @@ public void case7() throws Exception {
testAppId, 0, 0, 100, 1,
10, 1000, "", blockIdBitmap, taskIdBitmap,
Lists.newArrayList(shuffleServerInfo2), null, new DefaultIdHelper());
- assertTrue(readClient.readShuffleBlockData() == null);
+ try {
+ readClient.readShuffleBlockData();
+ fail();
+ } catch (RssException e) {
+ // ignore
Review Comment:
Could you add some log to help diagnose when tests are broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r980686612
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/ComposedClientReadHandler.java:
##########
@@ -127,7 +127,7 @@ public ShuffleDataResult readShuffleData() {
return null;
}
} catch (Exception e) {
- LOG.error("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
+ throw new RssException("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
Review Comment:
Make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r980793720
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/ComposedClientReadHandler.java:
##########
@@ -127,7 +127,7 @@ public ShuffleDataResult readShuffleData() {
return null;
}
} catch (Exception e) {
- LOG.error("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
+ throw new RssException("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
Review Comment:
> I think it wont happen that client reads the incomplete blocks from server's memory.
>
> I think we should handle all the retriable exceptions and then fail fast for other exceptions.
Is it possible to read incomplete local file data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r980676557
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/ComposedClientReadHandler.java:
##########
@@ -127,7 +127,7 @@ public ShuffleDataResult readShuffleData() {
return null;
}
} catch (Exception e) {
- LOG.error("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
+ throw new RssException("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
Review Comment:
Why do we need to throw this exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] frankliee commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
frankliee commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r977828151
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -533,6 +534,12 @@ public void getLocalShuffleIndex(GetLocalShuffleIndexRequest request,
builder.setIndexData(UnsafeByteOperations.unsafeWrap(data));
reply = builder.build();
+ } catch (FileNotFoundException indexFileNotFoundException) {
+ LOG.warn("Errors on getting localstorage index file for {}, maybe the data has been flushed to cold storage.",
Review Comment:
I prefer the following description.
=>`Index file for {} is not found, maybe the data has been flushed to cold storage.`
##########
common/src/main/java/org/apache/uniffle/common/exception/FileNotFoundException.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.uniffle.common.exception;
+
+public class FileNotFoundException extends RuntimeException {
Review Comment:
Why not use `Java.io.FileNotFoundException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r981031854
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/ComposedClientReadHandler.java:
##########
@@ -127,7 +127,7 @@ public ShuffleDataResult readShuffleData() {
return null;
}
} catch (Exception e) {
- LOG.error("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
+ throw new RssException("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
Review Comment:
It wont. Refer https://github.com/apache/incubator-uniffle/blob/f1cb43fd3928daf845f8d5a6495e51f40a98ac10/common/src/main/java/org/apache/uniffle/common/util/RssUtils.java#L204-L232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r980680637
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/ComposedClientReadHandler.java:
##########
@@ -127,7 +127,7 @@ public ShuffleDataResult readShuffleData() {
return null;
}
} catch (Exception e) {
- LOG.error("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
+ throw new RssException("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
Review Comment:
> It should fast fail on network failure when reading shuffle data from memory/localfile/hdfs in ComposedClientReadHandler. If not, it will throw inconsistent blockIds and make users confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
jerqi merged PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r981037163
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/ComposedClientReadHandler.java:
##########
@@ -127,7 +127,7 @@ public ShuffleDataResult readShuffleData() {
return null;
}
} catch (Exception e) {
- LOG.error("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
+ throw new RssException("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
Review Comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#issuecomment-1246586606
Like discussion at dev mail list, we will freeze the code and cut 0.6 version branch in September 15, we will not merge this pr before I cut 0.6 version branch, are you ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r972798019
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/LocalFileServerReadHandler.java:
##########
@@ -80,7 +81,7 @@ private void prepareFilePath(
File baseFolder = new File(fullShufflePath);
if (!baseFolder.exists()) {
// the partition doesn't exist in this base folder, skip
- throw new RuntimeException("Can't find folder " + fullShufflePath);
+ throw new FileNotFoundException("Can't find folder " + fullShufflePath);
Review Comment:
Change exception to `FileNotFoundException` ，this should not be thrown to client.
For example:
When using the MEMORY_LOCALFILE_HDFS type, sometime, the localfile storage may be empty due to the big event flushed to HDFS directly. So when I want to fast fail in `ComposedClientReadHandler`, this problem should be involved. So this exception should be handled in server's grpc api and return the empty index result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] frankliee commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
frankliee commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r977861488
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -533,6 +534,12 @@ public void getLocalShuffleIndex(GetLocalShuffleIndexRequest request,
builder.setIndexData(UnsafeByteOperations.unsafeWrap(data));
reply = builder.build();
+ } catch (FileNotFoundException indexFileNotFoundException) {
+ LOG.warn("Errors on getting localstorage index file for {}, maybe the data has been flushed to cold storage.",
Review Comment:
The others are LT2M
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r980745561
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/ComposedClientReadHandler.java:
##########
@@ -127,7 +127,7 @@ public ShuffleDataResult readShuffleData() {
return null;
}
} catch (Exception e) {
- LOG.error("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
+ throw new RssException("Failed to read shuffle data from " + getCurrentHandlerName() + " handler", e);
Review Comment:
I think it wont happen that client reads the incomplete blocks from server's memory.
I think we should handle all the retriable exceptions and then fail fast for other exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org