You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/01/05 15:12:02 UTC

[GitHub] [commons-crypto] arturobernalg opened a new pull request #127: [CRYPTO-156] - Common Class Padding and Transform

arturobernalg opened a new pull request #127:
URL: https://github.com/apache/commons-crypto/pull/127


   In order to avoid duplicate code and try to unify the transformation of the token i think it's necessary create the next class:
   
   OpenSslTransform --> Utility code for dealing with different algorithm types
   OpenSslPadding --> Containg the enumeration of Cipher Algorithm Padding
   OpenSslAlgorithmMode --> Enumeration of Algorithm Mode.
   https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L208
   https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L422
   https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L47
   https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L399


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-crypto] coveralls commented on pull request #127: [CRYPTO-156] - Common Class Padding and Transform

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #127:
URL: https://github.com/apache/commons-crypto/pull/127#issuecomment-754722243


   
   [![Coverage Status](https://coveralls.io/builds/36098941/badge)](https://coveralls.io/builds/36098941)
   
   Coverage increased (+0.2%) to 82.834% when pulling **a0230dadb62beb40255080250709640a5fb3331b on arturobernalg:feature/CRYPTO-156** into **9c76b2c2499ca30c4e3ed84c86afed0bd82e4a1e on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org