You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/24 20:54:30 UTC
[GitHub] [trafficcontrol] mitchell852 opened a new pull request #5329: Adds a more powerful UI grid for changelogs
mitchell852 opened a new pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [ ] This PR fixes #REPLACE_ME OR is not related to any Issue <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- CDN in a Box
- Documentation
- Grove
- Traffic Control Client <!-- Please specify which; e.g. 'Python', 'Go', 'Java' -->
- Traffic Monitor
- Traffic Ops
- Traffic Ops ORT
- Traffic Portal
- Traffic Router
- Traffic Stats
- Traffic Vault
- CI tests
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
## If this is a bug fix, what versions of Traffic Control are affected?
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [ ] This PR includes tests OR I have explained why tests are unnecessary
- [ ] This PR includes documentation OR I have explained why documentation is unnecessary
- [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [ ] This PR includes any and all required license headers
- [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329#discussion_r530567578
##########
File path: traffic_portal/app/src/common/modules/dialog/input/dialog.input.tpl.html
##########
@@ -24,7 +24,7 @@ <h4 class="modal-title">{{::params.title}}</h4>
<div class="modal-body">
<p ng-bind-html="params.message"></p>
<form name="inputForm" novalidate>
- <input type="text" class="form-control" ng-model="inputValue" ng-maxlength="256">
+ <input type="{{params.type ? params.type : 'text'}}" class="form-control" ng-model="inputValue" ng-maxlength="256">
Review comment:
right but this is a generic component so didn't want to overload it so just enforcing that it's a number and validating once entered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329#discussion_r530576656
##########
File path: traffic_ops/traffic_ops_golang/server/update.go
##########
@@ -102,20 +102,6 @@ func UpdateHandler(w http.ResponseWriter, r *http.Request) {
return
}
- err = api.CreateChangeLogBuildMsg(
- api.ApiChange,
- api.Updated,
- inf.User,
- inf.Tx.Tx,
- "server-update-status",
- hostName,
- map[string]interface{}{"host_name": hostName},
- )
- if err != nil {
- api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, nil, errors.New("writing changelog: "+err.Error()))
- return
- }
-
Review comment:
```
// UpdateHandler implements an http handler that updates a server's upd_pending and reval_pending values.
func UpdateHandler(w http.ResponseWriter, r *http.Request) {
```
Yeah, this handler is specifically for the `servers/{id-or-name}/update` route who's sole purpose is to update upd_pending and reval_pending values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329#discussion_r530583276
##########
File path: traffic_portal/app/src/common/modules/dialog/input/dialog.input.tpl.html
##########
@@ -24,7 +24,7 @@ <h4 class="modal-title">{{::params.title}}</h4>
<div class="modal-body">
<p ng-bind-html="params.message"></p>
<form name="inputForm" novalidate>
- <input type="text" class="form-control" ng-model="inputValue" ng-maxlength="256">
+ <input type="{{params.type ? params.type : 'text'}}" class="form-control" ng-model="inputValue" ng-maxlength="256">
Review comment:
I was going to suggest you use an `*ngIf`-`else` to insert different inputs depending on the type, but it turns out that only works in Angular, not AngularJS. In AngularJS you'd just need to do two `ng-if`s which is kind of a cludgy solution. So never mind, I guess.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329#discussion_r530567578
##########
File path: traffic_portal/app/src/common/modules/dialog/input/dialog.input.tpl.html
##########
@@ -24,7 +24,7 @@ <h4 class="modal-title">{{::params.title}}</h4>
<div class="modal-body">
<p ng-bind-html="params.message"></p>
<form name="inputForm" novalidate>
- <input type="text" class="form-control" ng-model="inputValue" ng-maxlength="256">
+ <input type="{{params.type ? params.type : 'text'}}" class="form-control" ng-model="inputValue" ng-maxlength="256">
Review comment:
right but this is a generic component so didn't want to overload it so just enforcing that it's a number and validating the range in the callback function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329#discussion_r530576656
##########
File path: traffic_ops/traffic_ops_golang/server/update.go
##########
@@ -102,20 +102,6 @@ func UpdateHandler(w http.ResponseWriter, r *http.Request) {
return
}
- err = api.CreateChangeLogBuildMsg(
- api.ApiChange,
- api.Updated,
- inf.User,
- inf.Tx.Tx,
- "server-update-status",
- hostName,
- map[string]interface{}{"host_name": hostName},
- )
- if err != nil {
- api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, nil, errors.New("writing changelog: "+err.Error()))
- return
- }
-
Review comment:
```
// UpdateHandler implements an http handler that updates a server's upd_pending and reval_pending values.
func UpdateHandler(w http.ResponseWriter, r *http.Request) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329#discussion_r530566548
##########
File path: traffic_ops/traffic_ops_golang/server/update.go
##########
@@ -102,20 +102,6 @@ func UpdateHandler(w http.ResponseWriter, r *http.Request) {
return
}
- err = api.CreateChangeLogBuildMsg(
- api.ApiChange,
- api.Updated,
- inf.User,
- inf.Tx.Tx,
- "server-update-status",
- hostName,
- map[string]interface{}{"host_name": hostName},
- )
- if err != nil {
- api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, nil, errors.New("writing changelog: "+err.Error()))
- return
- }
-
Review comment:
i'll look again but i was pretty sure this is just when Servers are "unqueued" or "unrevaled". So basically if the upd_pending or reval_pending flags are set back to false which can potentially happen thousands of times for every server queue/reval.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329#discussion_r530567290
##########
File path: traffic_portal/app/src/common/models/PropertiesModel.js
##########
@@ -21,6 +21,7 @@ var PropertiesModel = function() {
this.loaded = false;
this.setProperties = function(properties) {
+ if (this.loaded == true) return;
Review comment:
oh right. i like the `(this.loaded)` syntax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329#discussion_r530567714
##########
File path: traffic_portal/app/src/common/modules/table/changeLogs/table.changeLogs.tpl.html
##########
@@ -20,35 +20,45 @@
<div class="x_panel">
<div class="x_title">
<ol class="breadcrumb pull-left">
- <li class="active">Change Logs</li>
+ <li class="active">Change Logs <small>[ last <a ng-click="changeDays()">{{days}}</a> days ]</small></li>
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329#discussion_r530548390
##########
File path: traffic_ops/traffic_ops_golang/server/update.go
##########
@@ -102,20 +102,6 @@ func UpdateHandler(w http.ResponseWriter, r *http.Request) {
return
}
- err = api.CreateChangeLogBuildMsg(
- api.ApiChange,
- api.Updated,
- inf.User,
- inf.Tx.Tx,
- "server-update-status",
- hostName,
- map[string]interface{}{"host_name": hostName},
- )
- if err != nil {
- api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, nil, errors.New("writing changelog: "+err.Error()))
- return
- }
-
Review comment:
Do we no longer want changelogs when servers are updated?
##########
File path: traffic_portal/app/src/common/models/PropertiesModel.js
##########
@@ -21,6 +21,7 @@ var PropertiesModel = function() {
this.loaded = false;
this.setProperties = function(properties) {
+ if (this.loaded == true) return;
Review comment:
comparisons should use `===` - but also you don't need to compare booleans to constant values. `if (this.loaded)` works just fine.
##########
File path: traffic_portal/app/src/common/modules/dialog/input/dialog.input.tpl.html
##########
@@ -24,7 +24,7 @@ <h4 class="modal-title">{{::params.title}}</h4>
<div class="modal-body">
<p ng-bind-html="params.message"></p>
<form name="inputForm" novalidate>
- <input type="text" class="form-control" ng-model="inputValue" ng-maxlength="256">
+ <input type="{{params.type ? params.type : 'text'}}" class="form-control" ng-model="inputValue" ng-maxlength="256">
Review comment:
This will not enforce a min or max on numeric inputs, although your message states that log days should be between 1 and 365.
Also `ng-maxlength="{{some constant value}}"` can just be `maxlength="{{some constant value}}"`
##########
File path: traffic_portal/app/src/modules/private/changeLogs/list/index.js
##########
@@ -27,8 +27,12 @@ module.exports = angular.module('trafficPortal.private.changeLogs.list', [])
templateUrl: 'common/modules/table/changeLogs/table.changeLogs.tpl.html',
controller: 'TableChangeLogsController',
resolve: {
- changeLogs: function(changeLogService) {
- return changeLogService.getChangeLogs({ days: 3 });
+ tableName: function() {
+ return 'changeLogs';
+ },
+ changeLogs: function(changeLogService, propertiesModel) {
+ let days = (propertiesModel.properties.changeLogs) ? propertiesModel.properties.changeLogs.days : 7;
Review comment:
`days` is never reassigned, could be `const`
##########
File path: traffic_portal/app/src/common/modules/table/changeLogs/table.changeLogs.tpl.html
##########
@@ -20,35 +20,45 @@
<div class="x_panel">
<div class="x_title">
<ol class="breadcrumb pull-left">
- <li class="active">Change Logs</li>
+ <li class="active">Change Logs <small>[ last <a ng-click="changeDays()">{{days}}</a> days ]</small></li>
Review comment:
If this isn't a link, should use `button[type="button"]` instead of `a`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329#discussion_r530566548
##########
File path: traffic_ops/traffic_ops_golang/server/update.go
##########
@@ -102,20 +102,6 @@ func UpdateHandler(w http.ResponseWriter, r *http.Request) {
return
}
- err = api.CreateChangeLogBuildMsg(
- api.ApiChange,
- api.Updated,
- inf.User,
- inf.Tx.Tx,
- "server-update-status",
- hostName,
- map[string]interface{}{"host_name": hostName},
- )
- if err != nil {
- api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, nil, errors.New("writing changelog: "+err.Error()))
- return
- }
-
Review comment:
i'll look again but i was pretty sure this is just when Servers are "unqueued" or "unrevaled". So basically if the upd_pending or reval_pending flags are set back to false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5329: Adds a more powerful UI grid for changelogs and removes changelog entry for unqueuing servers updates/revals
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5329:
URL: https://github.com/apache/trafficcontrol/pull/5329#discussion_r530567578
##########
File path: traffic_portal/app/src/common/modules/dialog/input/dialog.input.tpl.html
##########
@@ -24,7 +24,7 @@ <h4 class="modal-title">{{::params.title}}</h4>
<div class="modal-body">
<p ng-bind-html="params.message"></p>
<form name="inputForm" novalidate>
- <input type="text" class="form-control" ng-model="inputValue" ng-maxlength="256">
+ <input type="{{params.type ? params.type : 'text'}}" class="form-control" ng-model="inputValue" ng-maxlength="256">
Review comment:
right but this is a generic component so didn't want to overload it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org