You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/05 18:51:50 UTC
[GitHub] [netbeans] DevCharly opened a new pull request #1848:
[NETBEANS-3666] improve performance of multitabs on startup if many files
are open
DevCharly opened a new pull request #1848: [NETBEANS-3666] improve performance of multitabs on startup if many files are open
URL: https://github.com/apache/netbeans/pull/1848
This is an attempt to fix/workaround the startup performance problem if many files are open and multitabs are used (which is not the default).
There are actually two problems:
1. `getPreferredWidth()` is invoked very often from the multitabs table listener (~60000 times for 200 open files)
2. the text (usually a filename) is always HTML (but does not contain other HTML tags), which involves slow HTML parsing
This PR addresses only 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1848:
[NETBEANS-3666] improve performance of multitabs on startup if many files
are open
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #1848: [NETBEANS-3666] improve performance of multitabs on startup if many files are open
URL: https://github.com/apache/netbeans/pull/1848#discussion_r363110646
##########
File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java
##########
@@ -141,6 +141,21 @@ int getPreferredWidth( Object value ) {
icon = i;
}
}
+
+ // On startup, this method is invoked very often if many files are open
+ // (~60000 times for 200 open files).
+ // The text (usually a filename) always starts with "<html>",
+ // but does not contain other HTML tags.
+ // The HTML rendering makes startup slow (and CPU load high).
+ // To workaround this, remove the leading "<html>" if text does not
+ // contain HTML tags or entities.
+ String prefix = "<html>";
Review comment:
//NOI18N at the end of the line please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #1848: [NETBEANS-3666]
improve performance of multitabs on startup if many files are open
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #1848: [NETBEANS-3666] improve performance of multitabs on startup if many files are open
URL: https://github.com/apache/netbeans/pull/1848
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #1848: [NETBEANS-3666]
improve performance of multitabs on startup if many files are open
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #1848: [NETBEANS-3666] improve performance of multitabs on startup if many files are open
URL: https://github.com/apache/netbeans/pull/1848#issuecomment-570948482
Next time you can really do an amended forced push for such small changes, so I can just rebase and merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #1848: [NETBEANS-3666]
improve performance of multitabs on startup if many files are open
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #1848: [NETBEANS-3666] improve performance of multitabs on startup if many files are open
URL: https://github.com/apache/netbeans/pull/1848#issuecomment-570937828
Seems to be pretty harmless.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1848: [NETBEANS-3666]
improve performance of multitabs on startup if many files are open
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1848: [NETBEANS-3666] improve performance of multitabs on startup if many files are open
URL: https://github.com/apache/netbeans/pull/1848#issuecomment-571145151
Nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists