You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/23 07:57:01 UTC
[GitHub] [thrift] Jimexist opened a new pull request, #2675: [java][lib] use check not test in gradle
Jimexist opened a new pull request, #2675:
URL: https://github.com/apache/thrift/pull/2675
<!-- Explain the changes in the pull request below: -->
use check not test in gradle
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2675: THRIFT-5638: [java][lib] use check not test in gradle
Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2675:
URL: https://github.com/apache/thrift/pull/2675#issuecomment-1256824895
this test fails because `ktfmt-gradle` actually will check for `generated-sources` dir but we'd like to exclude that for checking but not for compilation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2675: THRIFT-5638: [java][lib] use check not test in gradle
Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2675:
URL: https://github.com/apache/thrift/pull/2675#issuecomment-1257120434
> this test fails because `ktfmt-gradle` actually will check for `generated-sources` dir but we'd like to exclude that for checking but not for compilation
i put up the fix: to put the generated sources to test source set which resolves the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2675: THRIFT-5638: [java][lib] use check not test in gradle
Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2675:
URL: https://github.com/apache/thrift/pull/2675#issuecomment-1290686869
> I don't know enough about Gradle to understand the differences between test and check, but don't see anything to object to here.
note to myself: currently this is still failing because the gradle check will include spotless check on generated java files. there's no easy way to filter them out unless changes are to be made in the gradle plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org