[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3377: Quality of life improvements to consistent hash regex test form

[GitBox <gi...@apache.org>]

mitchell852 commented on a change in pull request #3377: Quality of life improvements to consistent hash regex test form
URL: https://github.com/apache/trafficcontrol/pull/3377#discussion_r263030167
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/form/deliveryServiceConsistentHashRegex/form.deliveryServiceConsistentHashRegex.tpl.html
 ##########
 @@ -30,25 +30,24 @@
         <br>
         <form name="dsConsistentHashRegexForm" class="form-horizontal form-label-left" novalidate>
             <div class="form-group" ng-class="{'has-error': hasError(dsConsistentHashRegexForm.pattern), 'has-feedback': hasError(dsConsistentHashRegexForm.pattern)}">
-                <label class="control-label col-md-2 col-sm-2 col-xs-12">Pattern *</label>
 
 Review comment:
   isn't pattern required? why remove the *?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services