You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/08 18:22:27 UTC
[GitHub] [lucene-solr] madrob opened a new pull request #1843: SOLR-14846 Remove Optional.ofNullable.orElse pattern
madrob opened a new pull request #1843:
URL: https://github.com/apache/lucene-solr/pull/1843
https://issues.apache.org/jira/browse/SOLR-14846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob merged pull request #1843: SOLR-14846 Remove Optional.ofNullable.orElse pattern
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #1843:
URL: https://github.com/apache/lucene-solr/pull/1843
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] vthacker commented on a change in pull request #1843: SOLR-14846 Remove Optional.ofNullable.orElse pattern
Posted by GitBox <gi...@apache.org>.
vthacker commented on a change in pull request #1843:
URL: https://github.com/apache/lucene-solr/pull/1843#discussion_r485154167
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java
##########
@@ -36,7 +35,7 @@
* by configured (optional).
* @return the {@linkplain SolrHttpClientBuilder}
*/
- public SolrHttpClientBuilder getHttpClientBuilder(Optional<SolrHttpClientBuilder> builder);
+ public SolrHttpClientBuilder getHttpClientBuilder(SolrHttpClientBuilder builder);
Review comment:
I'm wondering if this is a change we want to do in 9.0 only?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #1843: SOLR-14846 Remove Optional.ofNullable.orElse pattern
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #1843:
URL: https://github.com/apache/lucene-solr/pull/1843#discussion_r485210946
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java
##########
@@ -36,7 +35,7 @@
* by configured (optional).
* @return the {@linkplain SolrHttpClientBuilder}
*/
- public SolrHttpClientBuilder getHttpClientBuilder(Optional<SolrHttpClientBuilder> builder);
+ public SolrHttpClientBuilder getHttpClientBuilder(SolrHttpClientBuilder builder);
Review comment:
Yea, since we're changing APIs here, it would have to probably be 9 only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org