[GitHub] [yunikorn-k8shim] pbacsko commented on a diff in pull request #614: [YUNIKORN-1656] Update SI reference

["pbacsko (via GitHub)" <gi...@apache.org>]

pbacsko commented on code in PR #614:
URL: https://github.com/apache/yunikorn-k8shim/pull/614#discussion_r1229711188


##########
pkg/cache/context.go:
##########
@@ -935,11 +935,11 @@ func (ctx *Context) PublishEvents(eventRecords []*si.EventRecord) {
 		for _, record := range eventRecords {
 			switch record.Type {
 			case si.EventRecord_REQUEST:
-				taskID := record.ObjectID
-				appID := record.GroupID
+				appID := record.ObjectID
+				taskID := record.ReferenceID
 				if task := ctx.getTask(appID, taskID); task != nil {
 					events.GetRecorder().Eventf(task.GetTaskPod().DeepCopy(), nil,
-						v1.EventTypeNormal, record.Reason, record.Reason, record.Message)
+						v1.EventTypeNormal, "", "", record.Message)

Review Comment:
   I don't know, we might need a replacement. We no longer have the "reason" field in the message. I'll talk to Wilfred about this. For this PR, it's OK to leave it empty and we'll see what we do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org