[GitHub] [cassandra-dtest] driftx commented on a change in pull request #153: CASSANDRA-14309 Test hinted handoff window persistence

[GitBox <gi...@apache.org>]

driftx commented on a change in pull request #153:
URL: https://github.com/apache/cassandra-dtest/pull/153#discussion_r694910952



##########
File path: tools/data.py
##########
@@ -33,21 +36,19 @@ def insert_c1c2(session, keys=None, n=None, consistency=ConsistencyLevel.QUORUM)
 def query_c1c2(session, key, consistency=ConsistencyLevel.QUORUM, tolerate_missing=False, must_be_missing=False, max_attempts=1):
     query = SimpleStatement('SELECT c1, c2 FROM cf WHERE key=\'k%d\'' % key, consistency_level=consistency)
     rows = list(retry(lambda: session.execute(query), max_attempts=max_attempts))
-    if not tolerate_missing:
+    if not tolerate_missing and not must_be_missing: # we always tolerate missing if they must be missing

Review comment:
       Was this affecting rebuild_test?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org