You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/28 19:56:00 UTC
[GitHub] [spark] martin-g commented on pull request #35560: [SPARK-38351][TESTS] Don't use deprecate symbol API in test classes
martin-g commented on pull request #35560:
URL: https://github.com/apache/spark/pull/35560#issuecomment-1054608879
The build fails due to :
```
java.lang.RuntimeException: Failing because of negative scalastyle result
[error] at scala.sys.package$.error(package.scala:30)
[error] at org.scalastyle.sbt.Tasks$.handleResult$1(Plugin.scala:132)
[error] at org.scalastyle.sbt.Tasks$.doScalastyleWithConfig$1(Plugin.scala:187)
...
```
```
[error] /__w/spark/spark/sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala:580: File line length exceeds 100 characters
[error] /__w/spark/spark/sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala:927: File line length exceeds 100 characters
...
```
But executing `./dev/scalafmt` leads to many other unrelated formatting changes like:
```diff
import org.apache.spark.sql.catalyst.expressions.{InSet, Literal, NamedExpression}
-import org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{outstandingTimezonesIds, outstandingZoneIds}
+import org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{
+ outstandingTimezonesIds,
+ outstandingZoneIds
+}
import org.apache.spark.sql.catalyst.util.DateTimeUtils
import org.apache.spark.sql.execution.ProjectExec
import org.apache.spark.sql.functions._
@@ -43,83 +46,54 @@ class ColumnExpressionSuite extends QueryTest with SharedSparkSession {
import testImplicits._
private lazy val booleanData = {
- spark.createDataFrame(sparkContext.parallelize(
- Row(false, false) ::
- Row(false, true) ::
- Row(true, false) ::
- Row(true, true) :: Nil),
+ spark.createDataFrame(
+ sparkContext.parallelize(
+ Row(false, false) ::
+ Row(false, true) ::
+ Row(true, false) ::
+ Row(true, true) :: Nil),
```
It might take me a while to format manually just the related code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org