[jira] [Commented] (MESOS-3523) Teach cpplint to catch more coding style issues

["Marco Massenzio (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942868#comment-14942868 ] 

Marco Massenzio commented on MESOS-3523:
----------------------------------------

Just FYI - I have been submitting some PRs to the cpplint project on github, to allow us to configure it so that it is compatible with Mesos style guide ([0], [1]); unfortunately, they have been totally ignored.

My fork[2], in the {{master}} branch includes those patches, plus others, and would also include the "patching" we have in the Mesos repo (which I personally don't think is really maintainable) - feel free to try it out and suggest other fixes, I *do* look at PRs :)

BTW - the 70 columns limitation on comments is now gone, AFAIK.

[0] https://github.com/google/styleguide/pull/44
[1] https://github.com/google/styleguide/pull/46
[2] https://github.com/massenz/styleguide/tree/master

> Teach cpplint to catch more coding style issues
> -----------------------------------------------
>
>                 Key: MESOS-3523
>                 URL: https://issues.apache.org/jira/browse/MESOS-3523
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Cong Wang
>            Assignee: Marco Massenzio
>              Labels: mesosphere
>
> Our current cpplint hook can't catch the following coding style issues:
> 1. Two blank lines before public/private/protect, for example:
> {noformat}
> class foo{
> public:
>  foo();
> private:
>   int bar;
> protect:
>   int biz;
> };
> {noformat}
> 2. Braces not in the same line when the definition is empty, for example,
> {noformat}
> class Foo {
> private:
>   Foo()
>   {}
> };
> {noformat}
> 3. Comment line longer than 70 characters.
> 4. Initialization lists indention, for example
> {noformat}
> class Foo
> {
>   Foo()
>         : bar(_bar)
>   {}
> };
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)