You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/23 18:00:28 UTC

[GitHub] [arrow-datafusion] jgoday commented on pull request #394: #352: BallistaContext::collect() logging is too noisy

jgoday commented on pull request #394:
URL: https://github.com/apache/arrow-datafusion/pull/394#issuecomment-846601483


   > Thanks @jgoday. With this change we will never see output saying that the query is running unless we have trace logging enabled. Would it be possible to show the message with info logging on the first time we see that the job is running?
   
   Ok, Is ok if we use a flag (first time a job_id is logged) and define a macro info_or_trace_if like ?
   
   ```rust
   
   macro_rules! info_or_trace_if {
       ($first:ident, $($arg:tt)+) => (
           if $first {
               info!($($arg)+);
           } else {
               trace!($($arg)+);
           }
           $first = false;
       )
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org