You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2016/03/09 22:13:43 UTC
[GitHub] couchdb pull request: Emit heartbeats until feed timeout
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb/pull/389
Emit heartbeats until feed timeout
COUCHDB-2961
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb 2961-heartbeat-timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/389.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #389
----
commit 079467c21654ff1e9d18f557d7b2e28b6491ce65
Author: Alexander Shorin <kx...@apache.org>
Date: 2016-03-09T21:12:45Z
Emit heartbeats until feed timeout
COUCHDB-2961
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb issue #389: Emit heartbeats until feed timeout
Posted by wohali <gi...@git.apache.org>.
Github user wohali commented on the issue:
https://github.com/apache/couchdb/pull/389
@kxepal @rnewson any resolution here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Emit heartbeats until feed timeout
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/389#issuecomment-194983325
Heartbeats exists to ensure that connection is alive, active and operable, but not to keep it forever (this is actually should be done with timeout=infinity). We cannot relay on protocol level keep-alive because it actually doesn't works as everyone expects and only cause additional hangs (default may be minute to hours). Application level keep-alive is the only way to instantly figure out that things went wrong and time to reconnect. Websockets are effective in unreliable networks because of such approach (ping/pong).
Otherwise we have quite strange case when you do request `GET /db/_changes?feed=continuous&heartbeat=1000&timeout=60000` expecting that timeout will work as usually, but actually it get ignored. That's the first case. Another one is that helps to workaround COUCHDB-2912 issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Emit heartbeats until feed timeout
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/389#issuecomment-194813523
the heartbeat exists to keep a connection alive so is this a sensible thing to do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---