You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/05/12 02:51:06 UTC

Review Request 59221: RANGER-1574:The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The related redundant code should be deleted for plugin installer.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59221/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1574
    https://issues.apache.org/jira/browse/RANGER-1574


Repository: ranger


Description
-------

The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The following redundant code should be deleted for plugin installer because these codes will never be executed.
auditCredAlias="auditDBCred"	
auditdbCred=$(getInstallProperty 'XAAUDIT.DB.PASSWORD')
if [ "${auditdbCred}" != "" ]; then
	create_jceks "${auditCredAlias}"  "${auditdbCred}"  "${CredFile}"

I had checked the property for plugin-yarn, plugin-solr,plugin-kafka,plugin-atlas,hive-agent,hdfs-agent and hbase-agent. 
The test result shows that the modification is ok.


Diffs
-----

  agents-common/scripts/enable-agent.sh d13875c 


Diff: https://reviews.apache.org/r/59221/diff/1/


Testing
-------


Thanks,

pengjianhua

Re: Review Request 59221: RANGER-1574:The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The related redundant code should be deleted for plugin installer.

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59221/#review174866
-----------------------------------------------------------


Ship it!




Ship It!

- Qiang Zhang


On 五月 12, 2017, 1:20 p.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59221/
> -----------------------------------------------------------
> 
> (Updated 五月 12, 2017, 1:20 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1574
>     https://issues.apache.org/jira/browse/RANGER-1574
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The following redundant code should be deleted for plugin installer because these codes will never be executed.
> auditCredAlias="auditDBCred"	
> auditdbCred=$(getInstallProperty 'XAAUDIT.DB.PASSWORD')
> if [ "${auditdbCred}" != "" ]; then
> 	create_jceks "${auditCredAlias}"  "${auditdbCred}"  "${CredFile}"
> 
> I had checked the property for plugin-yarn, plugin-solr,plugin-kafka,plugin-atlas,hive-agent,hdfs-agent and hbase-agent. 
> The test result shows that the modification is ok.
> 
> 
> Diffs
> -----
> 
>   agents-common/scripts/enable-agent.sh d13875c 
>   hbase-agent/scripts/install.sh 265be1d 
>   hdfs-agent/scripts/install.sh ea88546 
>   hive-agent/scripts/install.sh fa19634 
>   knox-agent/scripts/install.sh 41322d3 
>   plugin-kms/scripts/enable-kms-plugin.sh 6101ef3 
>   storm-agent/scripts/install.sh 955ceb5 
> 
> 
> Diff: https://reviews.apache.org/r/59221/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59221: RANGER-1574:The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The related redundant code should be deleted for plugin installer.

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59221/#review174810
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 12, 2017, 1:20 p.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59221/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 1:20 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1574
>     https://issues.apache.org/jira/browse/RANGER-1574
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The following redundant code should be deleted for plugin installer because these codes will never be executed.
> auditCredAlias="auditDBCred"	
> auditdbCred=$(getInstallProperty 'XAAUDIT.DB.PASSWORD')
> if [ "${auditdbCred}" != "" ]; then
> 	create_jceks "${auditCredAlias}"  "${auditdbCred}"  "${CredFile}"
> 
> I had checked the property for plugin-yarn, plugin-solr,plugin-kafka,plugin-atlas,hive-agent,hdfs-agent and hbase-agent. 
> The test result shows that the modification is ok.
> 
> 
> Diffs
> -----
> 
>   agents-common/scripts/enable-agent.sh d13875c 
>   hbase-agent/scripts/install.sh 265be1d 
>   hdfs-agent/scripts/install.sh ea88546 
>   hive-agent/scripts/install.sh fa19634 
>   knox-agent/scripts/install.sh 41322d3 
>   plugin-kms/scripts/enable-kms-plugin.sh 6101ef3 
>   storm-agent/scripts/install.sh 955ceb5 
> 
> 
> Diff: https://reviews.apache.org/r/59221/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59221: RANGER-1574:The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The related redundant code should be deleted for plugin installer.

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59221/
-----------------------------------------------------------

(Updated May 12, 2017, 1:20 p.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1574
    https://issues.apache.org/jira/browse/RANGER-1574


Repository: ranger


Description
-------

The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The following redundant code should be deleted for plugin installer because these codes will never be executed.
auditCredAlias="auditDBCred"	
auditdbCred=$(getInstallProperty 'XAAUDIT.DB.PASSWORD')
if [ "${auditdbCred}" != "" ]; then
	create_jceks "${auditCredAlias}"  "${auditdbCred}"  "${CredFile}"

I had checked the property for plugin-yarn, plugin-solr,plugin-kafka,plugin-atlas,hive-agent,hdfs-agent and hbase-agent. 
The test result shows that the modification is ok.


Diffs (updated)
-----

  agents-common/scripts/enable-agent.sh d13875c 
  hbase-agent/scripts/install.sh 265be1d 
  hdfs-agent/scripts/install.sh ea88546 
  hive-agent/scripts/install.sh fa19634 
  knox-agent/scripts/install.sh 41322d3 
  plugin-kms/scripts/enable-kms-plugin.sh 6101ef3 
  storm-agent/scripts/install.sh 955ceb5 


Diff: https://reviews.apache.org/r/59221/diff/2/

Changes: https://reviews.apache.org/r/59221/diff/1-2/


Testing
-------


Thanks,

pengjianhua

Re: Review Request 59221: RANGER-1574:The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The related redundant code should be deleted for plugin installer.

Posted by pengjianhua <pe...@zte.com.cn>.

> On May 12, 2017, 10:07 a.m., Colm O hEigeartaigh wrote:
> > Why not remove it from the install scripts as well? e.g.
> > 
> > grep -rl "XAAUDIT.DB.PASSWORD" *
> > agents-common/scripts/enable-agent.sh
> > hbase-agent/scripts/install.sh
> > hdfs-agent/scripts/install.sh
> > hive-agent/scripts/install.sh
> > knox-agent/scripts/install.sh
> > plugin-kms/scripts/enable-kms-plugin.sh
> > storm-agent/scripts/install.sh
> 
> pengjianhua wrote:
>     Ok. I will carefully analyze these scripts and verify their functionality. I will remove these redundant codes if the verification result is ok.

Ok. I checked these files and remove it from these installers.The patch had been updated.Thanks.


- pengjianhua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59221/#review174773
-----------------------------------------------------------


On May 12, 2017, 1:20 p.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59221/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 1:20 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1574
>     https://issues.apache.org/jira/browse/RANGER-1574
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The following redundant code should be deleted for plugin installer because these codes will never be executed.
> auditCredAlias="auditDBCred"	
> auditdbCred=$(getInstallProperty 'XAAUDIT.DB.PASSWORD')
> if [ "${auditdbCred}" != "" ]; then
> 	create_jceks "${auditCredAlias}"  "${auditdbCred}"  "${CredFile}"
> 
> I had checked the property for plugin-yarn, plugin-solr,plugin-kafka,plugin-atlas,hive-agent,hdfs-agent and hbase-agent. 
> The test result shows that the modification is ok.
> 
> 
> Diffs
> -----
> 
>   agents-common/scripts/enable-agent.sh d13875c 
>   hbase-agent/scripts/install.sh 265be1d 
>   hdfs-agent/scripts/install.sh ea88546 
>   hive-agent/scripts/install.sh fa19634 
>   knox-agent/scripts/install.sh 41322d3 
>   plugin-kms/scripts/enable-kms-plugin.sh 6101ef3 
>   storm-agent/scripts/install.sh 955ceb5 
> 
> 
> Diff: https://reviews.apache.org/r/59221/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59221: RANGER-1574:The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The related redundant code should be deleted for plugin installer.

Posted by pengjianhua <pe...@zte.com.cn>.

> On 五月 12, 2017, 10:07 a.m., Colm O hEigeartaigh wrote:
> > Why not remove it from the install scripts as well? e.g.
> > 
> > grep -rl "XAAUDIT.DB.PASSWORD" *
> > agents-common/scripts/enable-agent.sh
> > hbase-agent/scripts/install.sh
> > hdfs-agent/scripts/install.sh
> > hive-agent/scripts/install.sh
> > knox-agent/scripts/install.sh
> > plugin-kms/scripts/enable-kms-plugin.sh
> > storm-agent/scripts/install.sh

Ok. I will carefully analyze these scripts and verify their functionality. I will remove these redundant codes if the verification result is ok.


- pengjianhua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59221/#review174773
-----------------------------------------------------------


On 五月 12, 2017, 2:51 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59221/
> -----------------------------------------------------------
> 
> (Updated 五月 12, 2017, 2:51 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1574
>     https://issues.apache.org/jira/browse/RANGER-1574
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The following redundant code should be deleted for plugin installer because these codes will never be executed.
> auditCredAlias="auditDBCred"	
> auditdbCred=$(getInstallProperty 'XAAUDIT.DB.PASSWORD')
> if [ "${auditdbCred}" != "" ]; then
> 	create_jceks "${auditCredAlias}"  "${auditdbCred}"  "${CredFile}"
> 
> I had checked the property for plugin-yarn, plugin-solr,plugin-kafka,plugin-atlas,hive-agent,hdfs-agent and hbase-agent. 
> The test result shows that the modification is ok.
> 
> 
> Diffs
> -----
> 
>   agents-common/scripts/enable-agent.sh d13875c 
> 
> 
> Diff: https://reviews.apache.org/r/59221/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59221: RANGER-1574:The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The related redundant code should be deleted for plugin installer.

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59221/#review174773
-----------------------------------------------------------



Why not remove it from the install scripts as well? e.g.

grep -rl "XAAUDIT.DB.PASSWORD" *
agents-common/scripts/enable-agent.sh
hbase-agent/scripts/install.sh
hdfs-agent/scripts/install.sh
hive-agent/scripts/install.sh
knox-agent/scripts/install.sh
plugin-kms/scripts/enable-kms-plugin.sh
storm-agent/scripts/install.sh

- Colm O hEigeartaigh


On May 12, 2017, 2:51 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59221/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 2:51 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1574
>     https://issues.apache.org/jira/browse/RANGER-1574
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The following redundant code should be deleted for plugin installer because these codes will never be executed.
> auditCredAlias="auditDBCred"	
> auditdbCred=$(getInstallProperty 'XAAUDIT.DB.PASSWORD')
> if [ "${auditdbCred}" != "" ]; then
> 	create_jceks "${auditCredAlias}"  "${auditdbCred}"  "${CredFile}"
> 
> I had checked the property for plugin-yarn, plugin-solr,plugin-kafka,plugin-atlas,hive-agent,hdfs-agent and hbase-agent. 
> The test result shows that the modification is ok.
> 
> 
> Diffs
> -----
> 
>   agents-common/scripts/enable-agent.sh d13875c 
> 
> 
> Diff: https://reviews.apache.org/r/59221/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>