You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hughhhh (via GitHub)" <gi...@apache.org> on 2023/06/12 22:05:28 UTC
[GitHub] [superset] hughhhh opened a new pull request, #24369: feat(sshtunnel): add configuration for SSH_TIMEOUT
hughhhh opened a new pull request, #24369:
URL: https://github.com/apache/superset/pull/24369
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add an additional configuration for setting `SSH_TIMEOUT` for `sshtunnel` package. The config allows us to set the timeout on individual packets.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24369: feat(sshtunnel): add configuration for SSH_TIMEOUT
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24369:
URL: https://github.com/apache/superset/pull/24369#issuecomment-1588184887
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24369?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24369](https://app.codecov.io/gh/apache/superset/pull/24369?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (538d01d) into [master](https://app.codecov.io/gh/apache/superset/commit/cd78ccb2c20b1001b1f3d824ff22a7af4be50590?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cd78ccb) will **decrease** coverage by `11.02%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 538d01d differs from pull request most recent head 914f7a6. Consider uploading reports for the commit 914f7a6 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24369 +/- ##
===========================================
- Coverage 69.05% 58.03% -11.02%
===========================================
Files 1903 1903
Lines 74537 74540 +3
Branches 8108 8108
===========================================
- Hits 51468 43263 -8205
- Misses 20957 29165 +8208
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.80% <100.00%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.72% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `60.61% <100.00%> (-22.72%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.21% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://app.codecov.io/gh/apache/superset/pull/24369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `70.31% <ø> (ø)` | |
| [superset/views/base.py](https://app.codecov.io/gh/apache/superset/pull/24369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `61.90% <ø> (-15.31%)` | :arrow_down: |
| [superset/config.py](https://app.codecov.io/gh/apache/superset/pull/24369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.40% <100.00%> (-0.53%)` | :arrow_down: |
| [superset/extensions/ssh.py](https://app.codecov.io/gh/apache/superset/pull/24369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy9zc2gucHk=) | `68.29% <100.00%> (+0.79%)` | :arrow_up: |
... and [300 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24369/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #24369: feat(sshtunnel): add configuration for SSH_TIMEOUT
Posted by "hughhhh (via GitHub)" <gi...@apache.org>.
hughhhh merged PR #24369:
URL: https://github.com/apache/superset/pull/24369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org