You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/27 15:20:29 UTC

[GitHub] [spark] MichaelChirico opened a new pull request #28372: [R] vectorize schema validation for arrow in types.R

MichaelChirico opened a new pull request #28372:
URL: https://github.com/apache/spark/pull/28372


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   Repeated `sapply` avoided in internal `checkSchemaInArrow`
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   Current implementation is doubly inefficient:
   
    1. Repeatedly doing the same (95%) `sapply` loop
    2. Doing scalar `==` on a vector (`==` should be done over the whole vector for efficiency)
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   No
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   By my trusty friend the CI bots


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620083477






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28372:
URL: https://github.com/apache/spark/pull/28372#discussion_r416251165



##########
File path: R/pkg/R/types.R
##########
@@ -94,27 +94,23 @@ checkSchemaInArrow <- function(schema) {
   }
 
   # Both cases below produce a corrupt value for unknown reason. It needs to be investigated.
-  if (any(sapply(schema$fields(), function(x) x$dataType.toString() == "FloatType"))) {
+  field_strings <- sapply(schema$fields(), function(x) x$dataType.toString())
+  if (any(field_strings == "FloatType")) {
     stop("Arrow optimization in R does not support float type yet.")
   }
-  if (any(sapply(schema$fields(), function(x) x$dataType.toString() == "BinaryType"))) {
+  if (any(field_strings == "BinaryType")) {
     stop("Arrow optimization in R does not support binary type yet.")
   }
-  if (any(sapply(schema$fields(),
-                 function(x) startsWith(x$dataType.toString(),
-                 "ArrayType")))) {
+  if (any(startsWith(field_strings, "ArrayType"))) {
     stop("Arrow optimization in R does not support array type yet.")
   }
 
   # Arrow optimization in Spark does not yet support both cases below.
-  if (any(sapply(schema$fields(),
-                 function(x) startsWith(x$dataType.toString(),
-                 "StructType")))) {
+  if (any(startsWith(field_strings, "StructType"))) {
     stop("Arrow optimization in R does not support nested struct type yet.")
   }
-  if (any(sapply(schema$fields(),
-                 function(x) startsWith(x$dataType.toString(),
-                 "MapType")))) {
+  if (any(startsWith(field_strings, "MapType"))) {
     stop("Arrow optimization in R does not support map type yet.")
   }
+  return(invisible())

Review comment:
       I think this is fine. Let's just remove unless this is explicitly recommended, conventional or consistent across the codebase :-).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MichaelChirico commented on a change in pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
MichaelChirico commented on a change in pull request #28372:
URL: https://github.com/apache/spark/pull/28372#discussion_r416249467



##########
File path: R/pkg/R/types.R
##########
@@ -94,27 +94,23 @@ checkSchemaInArrow <- function(schema) {
   }
 
   # Both cases below produce a corrupt value for unknown reason. It needs to be investigated.
-  if (any(sapply(schema$fields(), function(x) x$dataType.toString() == "FloatType"))) {
+  field_strings <- sapply(schema$fields(), function(x) x$dataType.toString())
+  if (any(field_strings == "FloatType")) {
     stop("Arrow optimization in R does not support float type yet.")
   }
-  if (any(sapply(schema$fields(), function(x) x$dataType.toString() == "BinaryType"))) {
+  if (any(field_strings == "BinaryType")) {
     stop("Arrow optimization in R does not support binary type yet.")
   }
-  if (any(sapply(schema$fields(),
-                 function(x) startsWith(x$dataType.toString(),
-                 "ArrayType")))) {
+  if (any(startsWith(field_strings, "ArrayType"))) {
     stop("Arrow optimization in R does not support array type yet.")
   }
 
   # Arrow optimization in Spark does not yet support both cases below.
-  if (any(sapply(schema$fields(),
-                 function(x) startsWith(x$dataType.toString(),
-                 "StructType")))) {
+  if (any(startsWith(field_strings, "StructType"))) {
     stop("Arrow optimization in R does not support nested struct type yet.")
   }
-  if (any(sapply(schema$fields(),
-                 function(x) startsWith(x$dataType.toString(),
-                 "MapType")))) {
+  if (any(startsWith(field_strings, "MapType"))) {
     stop("Arrow optimization in R does not support map type yet.")
   }
+  return(invisible())

Review comment:
       Just to be explicit about a void return value. Not strictly necessary. Happy to remove.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620060135


   **[Test build #121915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121915/testReport)** for PR 28372 at commit [`8004d22`](https://github.com/apache/spark/commit/8004d221bf860faf057d2f997d5b15f1592eb5c8).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620114852


   **[Test build #121918 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121918/testReport)** for PR 28372 at commit [`03b7898`](https://github.com/apache/spark/commit/03b7898acf2443bafab687043b494e1006615c40).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620060135


   **[Test build #121915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121915/testReport)** for PR 28372 at commit [`8004d22`](https://github.com/apache/spark/commit/8004d221bf860faf057d2f997d5b15f1592eb5c8).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620068244


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620060954






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620082803


   **[Test build #121918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121918/testReport)** for PR 28372 at commit [`03b7898`](https://github.com/apache/spark/commit/03b7898acf2443bafab687043b494e1006615c40).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620055589


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620332859


   Merged to master and branch-3.0.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620332934






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620316932






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620332801


   **[Test build #121937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121937/testReport)** for PR 28372 at commit [`0c2718b`](https://github.com/apache/spark/commit/0c2718bdfc73c6913bf2d612910744a4591eb1f8).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620115307






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620055571


   **[Test build #121913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121913/testReport)** for PR 28372 at commit [`0fc8513`](https://github.com/apache/spark/commit/0fc8513fb407fa6b532b5a0bbbe61dcabc92298b).
    * This patch **fails some tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620068244






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620332934






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620316932






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620331533


   I am going to merge. The tests are already passed, and I don't believe removing the return causes any test or build to break.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620115307






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28372:
URL: https://github.com/apache/spark/pull/28372#discussion_r416247772



##########
File path: R/pkg/R/types.R
##########
@@ -94,27 +94,23 @@ checkSchemaInArrow <- function(schema) {
   }
 
   # Both cases below produce a corrupt value for unknown reason. It needs to be investigated.
-  if (any(sapply(schema$fields(), function(x) x$dataType.toString() == "FloatType"))) {
+  field_strings <- sapply(schema$fields(), function(x) x$dataType.toString())
+  if (any(field_strings == "FloatType")) {
     stop("Arrow optimization in R does not support float type yet.")
   }
-  if (any(sapply(schema$fields(), function(x) x$dataType.toString() == "BinaryType"))) {
+  if (any(field_strings == "BinaryType")) {
     stop("Arrow optimization in R does not support binary type yet.")
   }
-  if (any(sapply(schema$fields(),
-                 function(x) startsWith(x$dataType.toString(),
-                 "ArrayType")))) {
+  if (any(startsWith(field_strings, "ArrayType"))) {
     stop("Arrow optimization in R does not support array type yet.")
   }
 
   # Arrow optimization in Spark does not yet support both cases below.
-  if (any(sapply(schema$fields(),
-                 function(x) startsWith(x$dataType.toString(),
-                 "StructType")))) {
+  if (any(startsWith(field_strings, "StructType"))) {
     stop("Arrow optimization in R does not support nested struct type yet.")
   }
-  if (any(sapply(schema$fields(),
-                 function(x) startsWith(x$dataType.toString(),
-                 "MapType")))) {
+  if (any(startsWith(field_strings, "MapType"))) {
     stop("Arrow optimization in R does not support map type yet.")
   }
+  return(invisible())

Review comment:
       Quick question, why do we need this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620055491


   **[Test build #121913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121913/testReport)** for PR 28372 at commit [`0fc8513`](https://github.com/apache/spark/commit/0fc8513fb407fa6b532b5a0bbbe61dcabc92298b).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620316474


   **[Test build #121937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121937/testReport)** for PR 28372 at commit [`0c2718b`](https://github.com/apache/spark/commit/0c2718bdfc73c6913bf2d612910744a4591eb1f8).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MichaelChirico commented on pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
MichaelChirico commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620331958


   linter failure looks transient to me:
   
   > E: The repository 'https://cloud.r-project.org/bin/linux/ubuntu bionic-cran35/ Release' does not have a Release file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620056207






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620055599






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620083477






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] Vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620316474


   **[Test build #121937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121937/testReport)** for PR 28372 at commit [`0c2718b`](https://github.com/apache/spark/commit/0c2718bdfc73c6913bf2d612910744a4591eb1f8).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620068253


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121915/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620060954






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620068202


   **[Test build #121915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121915/testReport)** for PR 28372 at commit [`8004d22`](https://github.com/apache/spark/commit/8004d221bf860faf057d2f997d5b15f1592eb5c8).
    * This patch **fails R style tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620055589






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620082803


   **[Test build #121918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121918/testReport)** for PR 28372 at commit [`03b7898`](https://github.com/apache/spark/commit/03b7898acf2443bafab687043b494e1006615c40).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28372: [SPARK-31578][R] vectorize schema validation for arrow in types.R

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620055491


   **[Test build #121913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121913/testReport)** for PR 28372 at commit [`0fc8513`](https://github.com/apache/spark/commit/0fc8513fb407fa6b532b5a0bbbe61dcabc92298b).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org