You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@qpid.apache.org by Fraser Adams <fr...@blueyonder.co.uk> on 2014/02/15 17:55:32 UTC

Qpid trunk r1568639 cpp build fails on ha_test_max_queues.cpp

Hello all,
I've just done an svn update to r1568639 and tried to build qpid cpp

I did
cmake -DCMAKE_BUILD_TYPE=Release ..
and also, just to check
cmake ..

both fail for me using gcc 4.6.1

I got as far as below - seems to be a problem with ha_test_max_queues.cpp


Scanning dependencies of target ha_test_max_queues
[ 80%] Building CXX object 
src/tests/CMakeFiles/ha_test_max_queues.dir/ha_test_max_queues.cpp.o
/home/fadams/qpid/qpid-trunk/qpid/cpp/src/tests/ha_test_max_queues.cpp:32:5: 
error: unused parameter ‘argc’ [-Werror=unused-parameter]
cc1plus: all warnings being treated as errors

make[2]: *** 
[src/tests/CMakeFiles/ha_test_max_queues.dir/ha_test_max_queues.cpp.o] 
Error 1
make[1]: *** [src/tests/CMakeFiles/ha_test_max_queues.dir/all] Error 2
make: *** [all] Error 2


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: Qpid trunk r1568639 cpp build fails on ha_test_max_queues.cpp

Posted by Fraser Adams <fr...@blueyonder.co.uk>.
On 18/02/14 20:04, Andrew Stitcher wrote:
> On Tue, 2014-02-18 at 19:47 +0000, Fraser Adams wrote:
>> Hi Andrew.
>> I actually completely removed the bld directory before I tried this
>> again after Alan fixed the ha_test_max_queues.cpp stuff (and I did a
>> make uninstall before I did any of it) so I'm fairly sure both stores
>> are still being installed.
> Ah, in which case you can turn one of the stores off (until we properly
> fix it) in ccmake - the options are BUILD_LINEARSTORE and
> BUILD_LEGACYSTORE
>
> or when intially running
> 	cmake -DBUILD_LINEARSTORE=no ...
> or
> 	cmake -DBUILD_LEGACYSTORE=no ...
>
> A
>
>
Thanks Andrew that's neater, though I definitely think it needs to have 
a "work by default" mode for the 0.28 release. If things don't "just 
work" there's a danger of putting people off.

Incidentally I also raised a Jira 5493 a bit back relating to the 
general lack of documentation around persistence. TBH it looks  like 
there has been a huge amount of work put into qpidd persistence of late 
and it seems a real shame that there's nothing obvious on how to 
actually use it. I wouldn't even know where to start - even when I 
delete legacystore.so I'm greeted with

2014-02-18 19:21:51 [Store] notice Linear Store: Store module 
initialized; store-dir=/home/fadams/.qpidd
2014-02-18 19:21:51 [Store] warning Message store plugin: No storage 
providers available.

So something is clearly working, but something clearly not.

Even a quick README would be a start (have I simply missed it?). It's 
not a real show stopper for me personally as I don't tend to need 
persistence for most of my stuff, but as I say it seems something of a 
shame given the obvious work that has gone on to put the code together.

Cheers,
Frase



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: Qpid trunk r1568639 cpp build fails on ha_test_max_queues.cpp

Posted by Andrew Stitcher <as...@redhat.com>.
On Tue, 2014-02-18 at 19:47 +0000, Fraser Adams wrote:
> Hi Andrew.
> I actually completely removed the bld directory before I tried this 
> again after Alan fixed the ha_test_max_queues.cpp stuff (and I did a 
> make uninstall before I did any of it) so I'm fairly sure both stores 
> are still being installed.

Ah, in which case you can turn one of the stores off (until we properly
fix it) in ccmake - the options are BUILD_LINEARSTORE and
BUILD_LEGACYSTORE

or when intially running
	cmake -DBUILD_LINEARSTORE=no ...
or
	cmake -DBUILD_LEGACYSTORE=no ...

A



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: Qpid trunk r1568639 cpp build fails on ha_test_max_queues.cpp

Posted by Fraser Adams <fr...@blueyonder.co.uk>.
Hi Andrew.
I actually completely removed the bld directory before I tried this 
again after Alan fixed the ha_test_max_queues.cpp stuff (and I did a 
make uninstall before I did any of it) so I'm fairly sure both stores 
are still being installed.
Frase


On 18/02/14 19:40, Andrew Stitcher wrote:
> On Tue, 2014-02-18 at 19:20 +0000, Fraser Adams wrote:
>> ...
>> So basically both stores are installed by default, which means qpidd
>> fails to start by default, which seems less than ideal.
> I think (not 100% sure though) this is because you have a CMakeCache
> which was created before we fixed the problem. Remove it and run cmake
> again then I think you should only get one store module.
>
> A
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: Qpid trunk r1568639 cpp build fails on ha_test_max_queues.cpp

Posted by Andrew Stitcher <as...@redhat.com>.
On Tue, 2014-02-18 at 19:20 +0000, Fraser Adams wrote:
> ...
> So basically both stores are installed by default, which means qpidd 
> fails to start by default, which seems less than ideal.

I think (not 100% sure though) this is because you have a CMakeCache
which was created before we fixed the problem. Remove it and run cmake
again then I think you should only get one store module.

A


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: Qpid trunk r1568639 cpp build fails on ha_test_max_queues.cpp

Posted by Fraser Adams <fr...@blueyonder.co.uk>.
Hi again Alan,
I've just tried this and it compiles fine this time - thanks, however 
I'm still seeing the (unrelated) issue that I reported a couple of weeks ago

qpidd --auth no
2014-02-18 19:07:16 [Store] notice Journal "TplStore": Created
2014-02-18 19:07:16 [Store] notice Store module initialized; 
store-dir=/home/fadams/.qpidd
2014-02-18 19:07:17 [Store] notice Linear Store: Journal "TplStore":Created
2014-02-18 19:07:17 [Store] notice Linear Store: EFP Manager 
initialization complete
2014-02-18 19:07:17 [Store] notice Linear Store: Store module 
initialized; store-dir=/home/fadams/.qpidd
2014-02-18 19:07:17 [Broker] error Multiple store plugins are not supported
2014-02-18 19:07:17 [Store] notice Journal "TplStore": Destroyed
2014-02-18 19:07:17 [Broker] critical Unexpected error: Failed to start 
broker: Multiple store plugins were loaded 
(/home/fadams/qpid/qpid-trunk/qpid/cpp/src/qpid/broker/Broker.cpp:424)
2014-02-18 19:07:17 [Store] notice Linear Store: Journal 
"TplStore":Destroyed


So basically both stores are installed by default, which means qpidd 
fails to start by default, which seems less than ideal.

It's easy to fix by deleting one of the store shared objects, but if 
0.28 release candidate is doing this I think it's a blocker. I raised 
https://issues.apache.org/jira/browse/QPID-5492 a month ago but there 
haven't been any comments on the Jira I didn't pursue it as I assumed 
that it might have been fixed but trying again when we're talking about 
a 0.28 release it seems worth flagging up again.

thoughts?

Frase




On 18/02/14 16:11, Alan Conway wrote:
> On Tue, 2014-02-18 at 11:04 -0500, Alan Conway wrote:
>> On Sat, 2014-02-15 at 16:55 +0000, Fraser Adams wrote:
>>> Hello all,
>>> I've just done an svn update to r1568639 and tried to build qpid cpp
>>>
>>> I did
>>> cmake -DCMAKE_BUILD_TYPE=Release ..
>>> and also, just to check
>>> cmake ..
>>>
>>> both fail for me using gcc 4.6.1
>>>
>>> I got as far as below - seems to be a problem with ha_test_max_queues.cpp
>>>
>>>
>>> Scanning dependencies of target ha_test_max_queues
>>> [ 80%] Building CXX object
>>> src/tests/CMakeFiles/ha_test_max_queues.dir/ha_test_max_queues.cpp.o
>>> /home/fadams/qpid/qpid-trunk/qpid/cpp/src/tests/ha_test_max_queues.cpp:32:5:
>>> error: unused parameter ‘argc’ [-Werror=unused-parameter]
>>> cc1plus: all warnings being treated as errors
>>>
>>> make[2]: ***
>>> [src/tests/CMakeFiles/ha_test_max_queues.dir/ha_test_max_queues.cpp.o]
>>> Error 1
>>> make[1]: *** [src/tests/CMakeFiles/ha_test_max_queues.dir/all] Error 2
>>> make: *** [all] Error 2
>> My bad! That would be a release build right? Stupid assert(). Fixing
>> now...
> Fixed.
> ------------------------------------------------------------------------
> r1569400 | aconway | 2014-02-18 11:09:23 -0500 (Tue, 18 Feb 2014) | 4
> lines
>
> NO-JIRA: Fix build error in ha_test_max_queues for release builds.
>
> argc was only being tested in an assert which was compiled out for
> release builds.
>
> ------------------------------------------------------------------------
>
> Of course "stupid assert" is short for "stupid developer who should know
> better than to use assert like that..."
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: Qpid trunk r1568639 cpp build fails on ha_test_max_queues.cpp

Posted by Fraser Adams <fr...@blueyonder.co.uk>.
Hi Alan,
It also failed when I did cmake .. though I now can't remember if I 
remembered to clear the cache after I first did

cmake -DCMAKE_BUILD_TYPE=Release ..

:->

So it might well just relate to the Release build, looking at the code 
that'd make more sense. Thanks for fixing I'll give it another whirl
Frase

On 18/02/14 16:11, Alan Conway wrote:
> On Tue, 2014-02-18 at 11:04 -0500, Alan Conway wrote:
>> On Sat, 2014-02-15 at 16:55 +0000, Fraser Adams wrote:
>>> Hello all,
>>> I've just done an svn update to r1568639 and tried to build qpid cpp
>>>
>>> I did
>>> cmake -DCMAKE_BUILD_TYPE=Release ..
>>> and also, just to check
>>> cmake ..
>>>
>>> both fail for me using gcc 4.6.1
>>>
>>> I got as far as below - seems to be a problem with ha_test_max_queues.cpp
>>>
>>>
>>> Scanning dependencies of target ha_test_max_queues
>>> [ 80%] Building CXX object
>>> src/tests/CMakeFiles/ha_test_max_queues.dir/ha_test_max_queues.cpp.o
>>> /home/fadams/qpid/qpid-trunk/qpid/cpp/src/tests/ha_test_max_queues.cpp:32:5:
>>> error: unused parameter ‘argc’ [-Werror=unused-parameter]
>>> cc1plus: all warnings being treated as errors
>>>
>>> make[2]: ***
>>> [src/tests/CMakeFiles/ha_test_max_queues.dir/ha_test_max_queues.cpp.o]
>>> Error 1
>>> make[1]: *** [src/tests/CMakeFiles/ha_test_max_queues.dir/all] Error 2
>>> make: *** [all] Error 2
>> My bad! That would be a release build right? Stupid assert(). Fixing
>> now...
> Fixed.
> ------------------------------------------------------------------------
> r1569400 | aconway | 2014-02-18 11:09:23 -0500 (Tue, 18 Feb 2014) | 4
> lines
>
> NO-JIRA: Fix build error in ha_test_max_queues for release builds.
>
> argc was only being tested in an assert which was compiled out for
> release builds.
>
> ------------------------------------------------------------------------
>
> Of course "stupid assert" is short for "stupid developer who should know
> better than to use assert like that..."
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: Qpid trunk r1568639 cpp build fails on ha_test_max_queues.cpp

Posted by Alan Conway <ac...@redhat.com>.
On Tue, 2014-02-18 at 11:04 -0500, Alan Conway wrote:
> On Sat, 2014-02-15 at 16:55 +0000, Fraser Adams wrote:
> > Hello all,
> > I've just done an svn update to r1568639 and tried to build qpid cpp
> > 
> > I did
> > cmake -DCMAKE_BUILD_TYPE=Release ..
> > and also, just to check
> > cmake ..
> > 
> > both fail for me using gcc 4.6.1
> > 
> > I got as far as below - seems to be a problem with ha_test_max_queues.cpp
> > 
> > 
> > Scanning dependencies of target ha_test_max_queues
> > [ 80%] Building CXX object 
> > src/tests/CMakeFiles/ha_test_max_queues.dir/ha_test_max_queues.cpp.o
> > /home/fadams/qpid/qpid-trunk/qpid/cpp/src/tests/ha_test_max_queues.cpp:32:5: 
> > error: unused parameter ‘argc’ [-Werror=unused-parameter]
> > cc1plus: all warnings being treated as errors
> > 
> > make[2]: *** 
> > [src/tests/CMakeFiles/ha_test_max_queues.dir/ha_test_max_queues.cpp.o] 
> > Error 1
> > make[1]: *** [src/tests/CMakeFiles/ha_test_max_queues.dir/all] Error 2
> > make: *** [all] Error 2
> 
> My bad! That would be a release build right? Stupid assert(). Fixing
> now...

Fixed.
------------------------------------------------------------------------
r1569400 | aconway | 2014-02-18 11:09:23 -0500 (Tue, 18 Feb 2014) | 4
lines

NO-JIRA: Fix build error in ha_test_max_queues for release builds.

argc was only being tested in an assert which was compiled out for
release builds.

------------------------------------------------------------------------

Of course "stupid assert" is short for "stupid developer who should know
better than to use assert like that..."



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: Qpid trunk r1568639 cpp build fails on ha_test_max_queues.cpp

Posted by Alan Conway <ac...@redhat.com>.
On Sat, 2014-02-15 at 16:55 +0000, Fraser Adams wrote:
> Hello all,
> I've just done an svn update to r1568639 and tried to build qpid cpp
> 
> I did
> cmake -DCMAKE_BUILD_TYPE=Release ..
> and also, just to check
> cmake ..
> 
> both fail for me using gcc 4.6.1
> 
> I got as far as below - seems to be a problem with ha_test_max_queues.cpp
> 
> 
> Scanning dependencies of target ha_test_max_queues
> [ 80%] Building CXX object 
> src/tests/CMakeFiles/ha_test_max_queues.dir/ha_test_max_queues.cpp.o
> /home/fadams/qpid/qpid-trunk/qpid/cpp/src/tests/ha_test_max_queues.cpp:32:5: 
> error: unused parameter ‘argc’ [-Werror=unused-parameter]
> cc1plus: all warnings being treated as errors
> 
> make[2]: *** 
> [src/tests/CMakeFiles/ha_test_max_queues.dir/ha_test_max_queues.cpp.o] 
> Error 1
> make[1]: *** [src/tests/CMakeFiles/ha_test_max_queues.dir/all] Error 2
> make: *** [all] Error 2

My bad! That would be a release build right? Stupid assert(). Fixing
now...



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org