You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/12/21 12:45:50 UTC
[GitHub] [incubator-brpc] lishoujun opened a new pull request #1308: Correct a spelling mistake
lishoujun opened a new pull request #1308:
URL: https://github.com/apache/incubator-brpc/pull/1308
correct a spelling mistake
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wasphin commented on a change in pull request #1308: Correct a spelling mistake
Posted by GitBox <gi...@apache.org>.
wasphin commented on a change in pull request #1308:
URL: https://github.com/apache/incubator-brpc/pull/1308#discussion_r547048999
##########
File path: src/brpc/controller.h
##########
@@ -340,7 +340,7 @@ friend void policy::ProcessThriftRequest(InputMessageBase*);
// and controller.cpp to know more.
void allow_done_to_run_in_place()
{ add_flag(FLAGS_ALLOW_DONE_TO_RUN_IN_PLACE); }
- // True iff above method was called.
Review comment:
This is not a typo, ``iff`` means if and only if
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] lishoujun closed pull request #1308: Correct a spelling mistake
Posted by GitBox <gi...@apache.org>.
lishoujun closed pull request #1308:
URL: https://github.com/apache/incubator-brpc/pull/1308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] lishoujun commented on a change in pull request #1308: Correct a spelling mistake
Posted by GitBox <gi...@apache.org>.
lishoujun commented on a change in pull request #1308:
URL: https://github.com/apache/incubator-brpc/pull/1308#discussion_r547178217
##########
File path: src/brpc/controller.h
##########
@@ -340,7 +340,7 @@ friend void policy::ProcessThriftRequest(InputMessageBase*);
// and controller.cpp to know more.
void allow_done_to_run_in_place()
{ add_flag(FLAGS_ALLOW_DONE_TO_RUN_IN_PLACE); }
- // True iff above method was called.
Review comment:
O, I see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org