You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/09 08:47:46 UTC
[GitHub] [skywalking-showcase] kezhenxu94 commented on a diff in pull request #29: Add feature function
kezhenxu94 commented on code in PR #29:
URL: https://github.com/apache/skywalking-showcase/pull/29#discussion_r846602515
##########
deploy/platform/kubernetes/features.mk:
##########
@@ -106,4 +106,24 @@ deploy.feature-java-agent-injector: install-cert-manager
undeploy.feature-java-agent-injector:
@curl -Ls https://archive.apache.org/dist/skywalking/swck/${SWCK_OPERATOR_VERSION}/skywalking-swck-${SWCK_OPERATOR_VERSION}-bin.tgz | tar -zxf - -O ./config/operator-bundle.yaml | kubectl delete --ignore-not-found -f -
@kubectl delete --ignore-not-found -f https://github.com/jetstack/cert-manager/releases/download/${CERT_MANAGER_VERSION}/cert-manager.yaml
- $(MAKE) undeploy FEATURE_FLAGS=agent AGENTLESS=false SHOW_TIPS=false BACKEND_SERVICE=$(BACKEND_SERVICE)
\ No newline at end of file
+ $(MAKE) undeploy FEATURE_FLAGS=agent AGENTLESS=false SHOW_TIPS=false BACKEND_SERVICE=$(BACKEND_SERVICE)
+
+.PHONY: open-function
+open-function: install-cert-manager
Review Comment:
Is `install-cert-manager` required by the open function indeed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org