You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/23 04:54:05 UTC

[GitHub] [incubator-superset] ktmud commented on pull request #10982: refactor: Replace reactable with DataTable from superset-ui in ChangeDatasourceModal

ktmud commented on pull request #10982:
URL: https://github.com/apache/incubator-superset/pull/10982#issuecomment-697128984


   You can wrap the `DataTable` in a styled div like the `TableChart` does: https://github.com/apache-superset/superset-ui/blob/516b4d57b88bbadfbabebdb84b4862ce210bd350/plugins/plugin-chart-table/src/TableChart.tsx#L285
   
   Here is the CSS: https://github.com/apache-superset/superset-ui/blob/516b4d57b88bbadfbabebdb84b4862ce210bd350/plugins/plugin-chart-table/src/Styles.tsx#L3
   
   `DataTable` is designed to be CSS-less so it is library-agnostic.
   
   Separate tables are needed to sticky headers because the scrollable container must contain only the table body (otherwise we could just use `position: sticky` on the `th` cells)---which was the original behavior of `jquery.DataTables` this component was created to replace..


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org