You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2014/11/26 06:34:44 UTC
Re: Review Request 28322: Introduce libevent clock implementation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28322/
-----------------------------------------------------------
(Updated Nov. 26, 2014, 5:34 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Rebased.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
3rdparty/libprocess/src/libevent_clock.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/28322/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28322: Introduce libevent clock implementation.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28322/#review63910
-----------------------------------------------------------
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28322/#comment106236>
See comments in previous review that added EventLoop::delay for libev.
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28322/#comment106235>
Can this return an error?
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28322/#comment106231>
Seconds seconds = Seconds(tval.tv_sec) + Microseconds(tval.tv_usec);
return seconds.value();
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28322/#comment106233>
Can 'timer_ev' be NULL? Do we need to check?
- Benjamin Hindman
On Dec. 3, 2014, 10:48 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28322/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 10:48 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/libevent.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28322/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28322: Introduce libevent clock implementation.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28322/#review66111
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28322/#comment109470>
FYI, as discussed out of this review, we replaced the dummy timer with a tight loop in EventLoop::run().
- Benjamin Hindman
On Dec. 19, 2014, 12:22 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28322/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 12:22 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/libevent.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28322/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28322: Introduce libevent clock implementation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28322/
-----------------------------------------------------------
(Updated Dec. 19, 2014, 12:22 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Change Depends On to reflect duration <-> timeval conversion.
Use Duration instead of double.
Style fixes.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/28322/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28322: Introduce libevent clock implementation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28322/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 7:16 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
remove struct keyword.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/28322/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28322: Introduce libevent clock implementation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28322/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 6:51 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Refactor based on EventLoop::delay() interface change.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/28322/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28322: Introduce libevent clock implementation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28322/
-----------------------------------------------------------
(Updated Dec. 3, 2014, 10:48 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Add some comments, clarify parameters.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/28322/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28322: Introduce libevent clock implementation.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28322/#review63718
-----------------------------------------------------------
Looks good - astonishing how much simpler the libevent clock implementation is.
However, it is a bit dense - can you easen it up a bit with some comments on how you are using the libevent api?
3rdparty/libprocess/src/libevent_clock.cpp
<https://reviews.apache.org/r/28322/#comment106010>
For those of us who doesn't speak libevent fully, what's going on here? :-)
3rdparty/libprocess/src/libevent_clock.cpp
<https://reviews.apache.org/r/28322/#comment105999>
s/nullptr/NULL/
3rdparty/libprocess/src/libevent_clock.cpp
<https://reviews.apache.org/r/28322/#comment105998>
Can you expand a little bit on the conversion? Maybe worth generalizing?
3rdparty/libprocess/src/libevent_clock.cpp
<https://reviews.apache.org/r/28322/#comment105997>
Same here
- Niklas Nielsen
On Dec. 3, 2014, 11:50 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28322/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 11:50 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/libevent.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28322/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28322: Introduce libevent clock implementation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28322/
-----------------------------------------------------------
(Updated Dec. 3, 2014, 7:50 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Rebased.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/28322/diff/
Testing
-------
Thanks,
Joris Van Remoortere