You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/12 17:22:06 UTC

[GitHub] [airflow] ashb opened a new pull request #14746: Further speed up Connexion API tests with pytest session fixtures

ashb opened a new pull request #14746:
URL: https://github.com/apache/airflow/pull/14746


   Creating the Flask API and Connexion take a significant amount of time
   to create, and each of these test modules creates the Flask app with the
   same set up "initializers".
   
   To make this work we had to switch away from `unittest.TestCase`, as
   pytest fixtures won't work with TestCase subclasses.
   
   The `configured_app` fixture is defined at the module level, otherwise
   each _subclass_ would have it's "own" module scope fixture.
   
   This takes the test time for api_connexion/endpoints down to sub-1 minute
   for me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb merged pull request #14746: Further speed up Connexion API tests with pytest session fixtures

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14746:
URL: https://github.com/apache/airflow/pull/14746


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #14746: Further speed up Connexion API tests with pytest session fixtures

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14746:
URL: https://github.com/apache/airflow/pull/14746#issuecomment-797637985


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org