[GitHub] [spark] dongjoon-hyun commented on a change in pull request #23905: [SPARK-24669][SQL] Refresh table before drop database cascade

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #23905: [SPARK-24669][SQL] Refresh table before drop database cascade
URL: https://github.com/apache/spark/pull/23905#discussion_r262712417
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
 ##########
 @@ -218,6 +218,11 @@ class SessionCatalog(
     if (dbName == DEFAULT_DATABASE) {
       throw new AnalysisException(s"Can not drop default database")
     }
+    if (cascade && databaseExists(dbName)) {
+      listTables(dbName).foreach { t =>
+        refreshTable(t)
 
 Review comment:
   The goal of this PR is invalidating the tables. So, let's use more narrow API here.
   ```scala
   -        refreshTable(t)
   +        invalidateCachedTable(QualifiedTableName(dbName, t.table))
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org