You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by tabish121 <gi...@git.apache.org> on 2018/03/02 20:05:58 UTC
[GitHub] activemq-artemis pull request #1928: ARTEMIS-1722 Don't copy message bytes u...
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1928
ARTEMIS-1722 Don't copy message bytes unless needed
Alternate patch that doesn't copy the message bytes unless doing a
redelivery or skipping delivery annotations in the original version of
the message. Proton-J will copy the bytes provided to the Sender's send
method so a copy isn't necessary on most common sends.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1722
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1928.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1928
----
commit 63b2e84fce76a9bf6c7cc3c9cef00b775457453c
Author: Timothy Bish <ta...@...>
Date: 2018-03-02T20:03:08Z
ARTEMIS-1722 Don't copy message bytes unless needed
Alternate patch that doesn't copy the message bytes unless doing a
redelivery or skipping delivery annotations in the original version of
the message. Proton-J will copy the bytes provided to the Sender's send
method so a copy isn't necessary on most common sends.
----
---
[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1928
Need @clebertsuconic to give it a look
---
[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1928
@franz1981 I've updated this PR with changes to the common path based on your suggestions to me over on my fork. Thanks for the review and ideas, even better now.
---
[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1928
@tabish121 I'm actually running tests... leave it with me
---
[GitHub] activemq-artemis pull request #1928: ARTEMIS-1722 Don't copy message bytes u...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1928
---
[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1928
If we want this in 2.5 I think we should merge it today.
---