You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by la...@apache.org on 2013/12/10 19:21:06 UTC
svn commit: r1549917 -
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Author: larsh
Date: Tue Dec 10 18:21:06 2013
New Revision: 1549917
URL: http://svn.apache.org/r1549917
Log:
HBASE-10117 Avoid synchronization in HRegionScannerImpl.isFilterDone
Modified:
hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Modified: hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java?rev=1549917&r1=1549916&r2=1549917&view=diff
==============================================================================
--- hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java (original)
+++ hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java Tue Dec 10 18:21:06 2013
@@ -3794,7 +3794,7 @@ public class HRegion implements HeapSize
// KeyValue indicating that limit is reached when scanning
private final KeyValue KV_LIMIT = new KeyValue();
private final byte [] stopRow;
- private Filter filter;
+ private final Filter filter;
private int batch;
private int isScan;
private boolean filterClosed = false;
@@ -3924,7 +3924,7 @@ public class HRegion implements HeapSize
outResults.addAll(tmpList);
}
resetFilters();
- if (isFilterDone()) {
+ if (isFilterDoneInternal()) {
return false;
}
return returnResult;
@@ -3987,6 +3987,10 @@ public class HRegion implements HeapSize
* @return True if a filter rules the scanner is over, done.
*/
public synchronized boolean isFilterDone() {
+ return isFilterDoneInternal();
+ }
+
+ private boolean isFilterDoneInternal() {
return this.filter != null && this.filter.filterAllRemaining();
}