You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2020/11/18 18:37:22 UTC
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16745
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
This patch disables metadata/test_catalogd_debug_actions
test on S3 builds due to its flakiness. The root cause of this
seems to be that listing time on S3 is variable and the test
becomes flaky because it measures the time taken by refresh
command after a certain debug action is set.
Testing:
1. Ran the test on my local environment to make sure it
compiles fine.
Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
---
M tests/common/skip.py
M tests/metadata/test_catalogd_debug_actions.py
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/16745/1
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 )
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 18:55:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 )
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7677/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 21:13:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 )
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Nov 2020 01:54:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 )
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7678/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 21:13:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16745 )
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
This patch disables metadata/test_catalogd_debug_actions
test on S3 builds due to its flakiness. The root cause of this
seems to be that listing time on S3 is variable and the test
becomes flaky because it measures the time taken by refresh
command after a certain debug action is set.
Testing:
1. Ran the test on my local environment to make sure it
compiles fine.
Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Reviewed-on: http://gerrit.cloudera.org:8080/16745
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/skip.py
M tests/metadata/test_catalogd_debug_actions.py
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16745
to look at the new patch set (#2).
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
This patch disables metadata/test_catalogd_debug_actions
test on S3 builds due to its flakiness. The root cause of this
seems to be that listing time on S3 is variable and the test
becomes flaky because it measures the time taken by refresh
command after a certain debug action is set.
Testing:
1. Ran the test on my local environment to make sure it
compiles fine.
Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
---
M tests/common/skip.py
M tests/metadata/test_catalogd_debug_actions.py
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/16745/2
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 )
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16745/1/tests/metadata/test_catalogd_debug_actions.py
File tests/metadata/test_catalogd_debug_actions.py:
http://gerrit.cloudera.org:8080/#/c/16745/1/tests/metadata/test_catalogd_debug_actions.py@22
PS1, Line 22:
> flake8: E302 expected 2 blank lines, found 1
Done
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 18:58:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 )
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16745/1/tests/metadata/test_catalogd_debug_actions.py
File tests/metadata/test_catalogd_debug_actions.py:
http://gerrit.cloudera.org:8080/#/c/16745/1/tests/metadata/test_catalogd_debug_actions.py@22
PS1, Line 22: @SkipIfS3.variable_listing_times
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 18:38:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 )
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 19:01:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 )
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6674/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 19:02:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 )
Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
......................................................................
Patch Set 2: Code-Review+2
Carrying forward +2 from Tim.
--
To view, visit http://gerrit.cloudera.org:8080/16745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
Gerrit-Change-Number: 16745
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 18:58:47 +0000
Gerrit-HasComments: No