You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/13 21:33:26 UTC

[GitHub] [airflow] danielhoherd commented on a change in pull request #20266: Chart: properly quote namespace names

danielhoherd commented on a change in pull request #20266:
URL: https://github.com/apache/airflow/pull/20266#discussion_r768138800



##########
File path: chart/tests/test_basic_helm_chart.py
##########
@@ -359,3 +359,8 @@ def test_invalid_dags_access_mode(self):
             'accessMode must be one of the following: "ReadWriteOnce", "ReadOnlyMany", "ReadWriteMany"'
             in ex_ctx.exception.stderr.decode()
         )
+
+    @parameterized.expand(["abc", "123", "123abc"])

Review comment:
       Related to https://github.com/astronomer/issues/issues/3813
   
   ```suggestion
       @parameterized.expand(["abc", "123", "123abc", "123-abc"])
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org