You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/02/13 14:25:46 UTC

[GitHub] aboudreault commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python

aboudreault commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python
URL: https://github.com/apache/tinkerpop/pull/1060#discussion_r256417177
 
 

 ##########
 File path: gremlin-python/src/main/jython/gremlin_python/structure/io/graphsonV3d0.py
 ##########
 @@ -513,17 +548,83 @@ class Int64IO(_NumberIO):
     graphson_type = "g:Int64"
     graphson_base_type = "Int64"
 
+    @classmethod
+    def dictify(cls, n, writer):
+        # if we exceed Java long range then we need a BigInteger
 
 Review comment:
   That is correct. Note that this serializer function is used by the BigIntegerIO as well. So otherwise.. we would have no way to write a `gx:BigInteger`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services