You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/08/09 18:39:13 UTC

[GitHub] matthiasblaesing commented on issue #662: [NETBEANS-1074] Module Review php.atoum

matthiasblaesing commented on issue #662: [NETBEANS-1074] Module Review php.atoum
URL: https://github.com/apache/incubator-netbeans/pull/662#issuecomment-411856121
 
 
   In general looks good - I would however ask you not to add rat excludes, but use the "licenseinfo.xml" facitlity to declare the license for the file without modifying it. Please have a look at:
   
   `xsl/licenseinfo.xml`
   
   I think that should cover your usecase. The benefit is, that in the end the file can be traced to the license info and the rat exclusion is modular.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists