You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/17 01:35:51 UTC

[GitHub] [spark] ulysses-you commented on a change in pull request #35544: [SPARK-38232][SQL] Explain formatted does not collect subqueries under query stage in AQE

ulysses-you commented on a change in pull request #35544:
URL: https://github.com/apache/spark/pull/35544#discussion_r808595586



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -527,6 +527,20 @@ class ExplainSuite extends ExplainSuiteHelper with DisableAdaptiveExecutionSuite
 class ExplainSuiteAE extends ExplainSuiteHelper with EnableAdaptiveExecutionSuite {
   import testImplicits._
 
+  /**
+   * Get the final plan explain after running the sql
+   */
+  private def withFinalPlanNormalizedExplain(query: String, mode: String)(f: String => Unit) = {

Review comment:
       we can, just missed that method




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org