You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Daniel John Debrunner (JIRA)" <ji...@apache.org> on 2008/02/25 19:08:53 UTC
[jira] Created: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
-----------------------------------------------------------------------------------------------------------------------------------
Key: DERBY-3461
URL: https://issues.apache.org/jira/browse/DERBY-3461
Project: Derby
Issue Type: Improvement
Components: JDBC, Services
Reporter: Daniel John Debrunner
Priority: Minor
One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Dibyendu Majumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572742#action_12572742 ]
Dibyendu Majumdar commented on DERBY-3461:
------------------------------------------
See DERBY-3451 for instructions on how to apply the patch.
Patch was created using Mercurial.
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
> Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573148#action_12573148 ]
Daniel John Debrunner commented on DERBY-3461:
----------------------------------------------
It's ok to leave the old versions of the patch attached to the Jira issue, it allows reviewers to compare patches to get an idea of what changed between them.
What did change in the patch that fixed a test failure? I was expecting to see a master file (*.out) modified, but I didn't see one.
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
> Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel John Debrunner updated DERBY-3461:
-----------------------------------------
Derby Info: (was: [Patch Available])
Patch committed: Revision: 633290 - Thanks Dibyendu.
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
> Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Dibyendu Majumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dibyendu Majumdar updated DERBY-3461:
-------------------------------------
Attachment: DERBY-3461_patch_1_r631372.txt
Updated patch to fix a test failure.
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
> Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Dibyendu Majumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dibyendu Majumdar updated DERBY-3461:
-------------------------------------
Derby Info: (was: [Patch Available])
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Dibyendu Majumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dibyendu Majumdar updated DERBY-3461:
-------------------------------------
Attachment: (was: DERBY-3461_patch_1_r631372.txt)
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Dibyendu Majumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dibyendu Majumdar updated DERBY-3461:
-------------------------------------
Attachment: DERBY-3461_patch_1_r631372.txt
The class EmbedSQLWarning is really an SQLWarning factory class. Therefore, it has been renamed to SQLWarningFactory.
The unused method generateCsSQLWarning() has been removed.
The remaining methods have been renamed to remove the reference to 'Embed'.
Since the re-factored class is generic, it has been moved to org.apache.derby.iapi.error package.
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
> Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Dibyendu Majumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dibyendu Majumdar updated DERBY-3461:
-------------------------------------
Derby Info: [Patch Available]
Junit test cases have passed, except for the demo tests which for some reason fails on Mac OS X, using Java 1.5. Same error as reported in DERBY-3451.
I also ran derbyall on CentOS 5.1 using Java 1.6. 250 tests were run, with 1 failure. The failure is in derbyall/derbylang/closed. It seems that the following line (appears twice) was unexpected:
Caused by: java.sql.SQLException: Database 'wombat' shutdown.
The failures do not seem to be related to the changes made in this patch.
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
> Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Dibyendu Majumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574031#action_12574031 ]
Dibyendu Majumdar commented on DERBY-3461:
------------------------------------------
Searched for SQLWarning in the master *.out files, could not find any.
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
> Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Dibyendu Majumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573297#action_12573297 ]
Dibyendu Majumdar commented on DERBY-3461:
------------------------------------------
The fix was to set ExceptionSeverity.WARNING_SEVERITY in the constructor call. I had missed this in the first patch. I will check why there isn't any *.out that needed to be modified.
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
> Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Dibyendu Majumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dibyendu Majumdar resolved DERBY-3461.
--------------------------------------
Resolution: Fixed
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
> Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-3461:
--------------------------------------
Fix Version/s: 10.4.1.3
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
> Fix For: 10.4.1.3
>
> Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Dibyendu Majumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dibyendu Majumdar reassigned DERBY-3461:
----------------------------------------
Assignee: Dibyendu Majumdar
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3461) EmbedSQLWarning should be renamed
SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby
specific implementation.
Posted by "Dibyendu Majumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dibyendu Majumdar updated DERBY-3461:
-------------------------------------
Derby Info: [Patch Available]
Patch is available. Test results will be recorded once the test runs complete.
> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3461
> URL: https://issues.apache.org/jira/browse/DERBY-3461
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Services
> Reporter: Daniel John Debrunner
> Assignee: Dibyendu Majumdar
> Priority: Minor
> Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.