[GitHub] [hudi] leesf commented on a diff in pull request #8133: [HUDI-5904] support more than one update actions in merge into table

["leesf (via GitHub)" <gi...@apache.org>]

leesf commented on code in PR #8133:
URL: https://github.com/apache/hudi/pull/8133#discussion_r1131055256


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestMergeIntoTable.scala:
##########
@@ -115,6 +116,65 @@ class TestMergeIntoTable extends HoodieSparkSqlTestBase with ScalaAssertionSuppo
     })
   }
 
+  test("Test MergeInto with more than once update actions") {
+    withRecordType()(withTempDir {tmp =>
+      val conf = new SparkConf().setAppName("insertDatasToHudi").setMaster("local[*]")
+      val spark = SparkSession.builder().config(conf)
+        .config("spark.serializer", "org.apache.spark.serializer.KryoSerializer")
+        .config("spark.sql.extensions", "org.apache.spark.sql.hudi.HoodieSparkSessionExtension")

Review Comment:
   these config can be removed and please refer to other tests.
   
   ```
         val conf = new SparkConf().setAppName("insertDatasToHudi").setMaster("local[*]")
         val spark = SparkSession.builder().config(conf)
           .config("spark.serializer", "org.apache.spark.serializer.KryoSerializer")
           .config("spark.sql.extensions", "org.apache.spark.sql.hudi.HoodieSparkSessionExtension")
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org