You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2019/02/22 10:53:26 UTC

[GitHub] DominikSuess commented on a change in pull request #1: SLING-8284 - updating parent pom & eliminating dependency on JcrResou…

DominikSuess commented on a change in pull request #1: SLING-8284 - updating parent pom & eliminating dependency on JcrResou…
URL: https://github.com/apache/sling-org-apache-sling-resourcecollection/pull/1#discussion_r259295755
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -25,8 +25,8 @@
     <parent>
         <groupId>org.apache.sling</groupId>
         <artifactId>sling</artifactId>
-        <version>31</version>
-        <relativePath/>
+        <version>34</version>
+        <relativePath>../../../parent/pom.xml</relativePath>
 
 Review comment:
   I thought it is good practice to always go with the latest parent - if You're refering to the relative path this is a merge artifact and regression as my initial patch was against an older version so could be dropped.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services