[GitHub] [skywalking] ascrutae commented on a change in pull request #2803: Fix Mysql 6.x plugin

[GitBox <gi...@apache.org>]

ascrutae commented on a change in pull request #2803: Fix Mysql 6.x plugin
URL: https://github.com/apache/skywalking/pull/2803#discussion_r289636298
 
 

 ##########
 File path: apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/JDBCDriverInterceptor.java
 ##########
 @@ -41,7 +41,7 @@
 
     @Override public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments,
         Class<?>[] argumentsTypes, Object ret) throws Throwable {
-        if (ret != null) {
+        if (ret instanceof EnhancedInstance) {
 
 Review comment:
   ```suggestion
           if (ret != null && ret instanceof EnhancedInstance) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services