You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/20 03:54:12 UTC
[GitHub] [lucene-solr] arafalov opened a new pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode
arafalov opened a new pull request #1896:
URL: https://github.com/apache/lucene-solr/pull/1896
# Description
**bin/solr create_core -c test** was failing if solr.xml for the server defined coreRootDirectory different from solr_home. That's because the utility code was assuming solr_home, but was then failing when invoking the server that expected it somewhere else.
# Solution
Check for extra parameter being present and fall back to solr_home.
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [X] I have developed this patch against the `master` branch.
- [X] I have run `./gradlew check`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on a change in pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode
Posted by GitBox <gi...@apache.org>.
arafalov commented on a change in pull request #1896:
URL: https://github.com/apache/lucene-solr/pull/1896#discussion_r492241814
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -1675,9 +1675,9 @@ protected void runImpl(CommandLine cli) throws Exception {
}
// convert raw JSON into user-friendly output
- solrHome = (String)systemInfo.get("solr_home");
- if (solrHome == null)
- solrHome = configsetsDir.getParentFile().getAbsolutePath();
+ coreRootDirectory = (String)systemInfo.get("solr_core_root");
Review comment:
It also had to be introduced, check SOLR-14878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on a change in pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode
Posted by GitBox <gi...@apache.org>.
arafalov commented on a change in pull request #1896:
URL: https://github.com/apache/lucene-solr/pull/1896#discussion_r492241814
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -1675,9 +1675,9 @@ protected void runImpl(CommandLine cli) throws Exception {
}
// convert raw JSON into user-friendly output
- solrHome = (String)systemInfo.get("solr_home");
- if (solrHome == null)
- solrHome = configsetsDir.getParentFile().getAbsolutePath();
+ coreRootDirectory = (String)systemInfo.get("solr_core_root");
Review comment:
It also had to be introduced, check SOLR-14878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov merged pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode
Posted by GitBox <gi...@apache.org>.
arafalov merged pull request #1896:
URL: https://github.com/apache/lucene-solr/pull/1896
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov merged pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode
Posted by GitBox <gi...@apache.org>.
arafalov merged pull request #1896:
URL: https://github.com/apache/lucene-solr/pull/1896
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #1896:
URL: https://github.com/apache/lucene-solr/pull/1896#discussion_r492238398
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -1675,9 +1675,9 @@ protected void runImpl(CommandLine cli) throws Exception {
}
// convert raw JSON into user-friendly output
- solrHome = (String)systemInfo.get("solr_home");
- if (solrHome == null)
- solrHome = configsetsDir.getParentFile().getAbsolutePath();
+ coreRootDirectory = (String)systemInfo.get("solr_core_root");
Review comment:
Can you help my understand where exactly solr_core_root is populated? I don't see it in SystemInfoHandler which I presume populates the response for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #1896:
URL: https://github.com/apache/lucene-solr/pull/1896#discussion_r492238398
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -1675,9 +1675,9 @@ protected void runImpl(CommandLine cli) throws Exception {
}
// convert raw JSON into user-friendly output
- solrHome = (String)systemInfo.get("solr_home");
- if (solrHome == null)
- solrHome = configsetsDir.getParentFile().getAbsolutePath();
+ coreRootDirectory = (String)systemInfo.get("solr_core_root");
Review comment:
Can you help my understand where exactly solr_core_root is populated? I don't see it in SystemInfoHandler which I presume populates the response for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org