[GitHub] [druid] clintropolis commented on a change in pull request #9096: confluent schema registry client to accept config and headers

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #9096: confluent schema registry client to accept config and headers
URL: https://github.com/apache/druid/pull/9096#discussion_r384926170
 
 

 ##########
 File path: extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/SchemaRegistryBasedAvroBytesDecoder.java
 ##########
 @@ -41,11 +44,18 @@
   @JsonCreator
   public SchemaRegistryBasedAvroBytesDecoder(
       @JsonProperty("url") String url,
-      @JsonProperty("capacity") Integer capacity
+      @JsonProperty("capacity") Integer capacity,
+      @JsonProperty("urls") @Nullable List<String> urls,
 
 Review comment:
   I think it would probably make sense to mark the `url` parameter as `@Deprecated` in favor of the new `urls` parameter. If you agree, I think we should remove mention of `url` from the avro extension documentation.
   
   Additionally, would you mind adding a JSON serialization/deserialization unit test for this class to make sure the new properties work as expected?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org