You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2018/09/06 16:48:03 UTC

[Bug 62685] New: Changes to hostname parsing in HttpParser breaks hostname with trailing dot

https://bz.apache.org/bugzilla/show_bug.cgi?id=62685

            Bug ID: 62685
           Summary: Changes to hostname parsing in HttpParser breaks
                    hostname with trailing dot
           Product: Tomcat 9
           Version: 9.0.8
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: major
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: yfilmps@gmail.com
  Target Milestone: -----

Following fix "Enable strict validation of the provided host name and port for
all connectors. Requests with invalid host names and/or ports will be rejected
with a 400 response. (markt) " is now restricting the use of trailing dot in
hostname.

As per RFC 1034 and information on this site
http://www.dns-sd.org/trailingdotsindomainnames.html trailing dot is perfectly
valid for a hostname.


The fix is very simple and if needed I can contribute to the fix as well.
Please suggest.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62685] Changes to hostname parsing in HttpParser breaks hostname with trailing dot

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62685

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Many thanks for the report, the analysis and the patch.

Fixed in:
- trunk for 9.0.13 onwards
- 8.5.x for 8.5.35 onwards
- 7.0.x for 7.0.91 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62685] Changes to hostname parsing in HttpParser breaks hostname with trailing dot

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62685

AG <yf...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yfilmps@gmail.com

--- Comment #1 from AG <yf...@gmail.com> ---
Created attachment 36134
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36134&action=edit
Possible fix with updated test cases

Change in the patch simply allows a hostname to end with a dot.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62685] Changes to hostname parsing in HttpParser breaks hostname with trailing dot

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62685

--- Comment #2 from AG <yf...@gmail.com> ---
This issue seems to exist for the following versions:
- trunk for 9.0.8 onwards
- 8.5.x for 8.5.31 onwards
- 8.0.x for 8.0.52 onwards
- 7.0.x for 7.0.87 onwards

This is the actual fix that causes hostnames with trailing dot to fail:
https://github.com/apache/tomcat85/commit/b6ac68e879033476aeb685980bb8bc6443172965

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62685] Changes to hostname parsing in HttpParser breaks hostname with trailing dot

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62685

--- Comment #4 from AG <yf...@gmail.com> ---
Very much appreciate for the quick resolution. Will test it again once the new
releases are out.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62685] Changes to hostname parsing in HttpParser breaks hostname with trailing dot

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62685

Ethan Close <et...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ethan.close@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org