You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Yifan Cai (Jira)" <ji...@apache.org> on 2021/02/17 23:00:03 UTC
[jira] [Comment Edited] (CASSANDRA-16385) Correctly serialize all
request responses - CASSANDRA-15946 followup
[ https://issues.apache.org/jira/browse/CASSANDRA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286057#comment-17286057 ]
Yifan Cai edited comment on CASSANDRA-16385 at 2/17/21, 10:59 PM:
------------------------------------------------------------------
Starting commit
CI Results:
||Branch||Source||Circle CI||Jenkins||
|trunk|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-16385-trunk-52361017-D200-4F09-841A-14D93DE35918]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-16385-trunk-52361017-D200-4F09-841A-14D93DE35918]|[build|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/384/pipeline]|
Circle and Jenkins result look good, except several known test failures. Double checked and should not be relevant to the patch.
was (Author: yifanc):
Starting commit
CI Results (pending):
|| Branch || Source || Circle CI || Jenkins ||
|trunk|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-16385-trunk-52361017-D200-4F09-841A-14D93DE35918]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-16385-trunk-52361017-D200-4F09-841A-14D93DE35918]|[build|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/384/pipeline]|
> Correctly serialize all request responses - CASSANDRA-15946 followup
> --------------------------------------------------------------------
>
> Key: CASSANDRA-16385
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16385
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Jon Meredith
> Assignee: Jon Meredith
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> When receiving a message, a 4.0 dtest instance reserializes messages to pass them through the dtest message filtering.
>
> The 4.0 internode messaging refactor does not expect to have to re-serialize response
> messages, so the workaround in CASSANDRA-15946 was just to register the ReadResponse serializer for all REQUEST_RESPONSE messages, however request response is used for other responses too.
> I'm attaching a patch that demonstrates the issue by adding a simple Paxos upgrade test to generate a PrepareResponse message that crashes the ReadResponse serializer, then reverts CASSANDRA-15946 and re-users the messaging service serialization method that checks the request callback if a serializer is not defined.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org