You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/05/01 19:17:00 UTC
[jira] [Work logged] (BEAM-9692) Clean Python DataflowRunner to use
portable pipelines
[ https://issues.apache.org/jira/browse/BEAM-9692?focusedWorklogId=429622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429622 ]
ASF GitHub Bot logged work on BEAM-9692:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/20 19:16
Start Date: 01/May/20 19:16
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #11452:
URL: https://github.com/apache/beam/pull/11452#discussion_r418694513
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -117,13 +117,15 @@ class DataflowRunner(PipelineRunner):
# TODO: Remove the apache_beam.pipeline dependency in CreatePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import CombineValuesPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import CreatePTransformOverride
- from apache_beam.runners.dataflow.ptransform_overrides import ReadPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import JrhReadPTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import ReadPTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import NativeReadPTransformOverride
- # Thesse overrides should be applied before the proto representation of the
+ # These overrides should be applied before the proto representation of the
# graph is created.
_PTRANSFORM_OVERRIDES = [
- CombineValuesPTransformOverride()
+ CombineValuesPTransformOverride(),
Review comment:
Correct, this change does not change the existing behavior, but the concern is that the existing behavior might be sub-optimal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 429622)
Time Spent: 2h 50m (was: 2h 40m)
> Clean Python DataflowRunner to use portable pipelines
> -----------------------------------------------------
>
> Key: BEAM-9692
> URL: https://issues.apache.org/jira/browse/BEAM-9692
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)