You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/10 14:06:40 UTC

[GitHub] [rocketmq-schema-registry] ferrirW opened a new pull request, #1: [RIP-42] Support schema registry basic feature

ferrirW opened a new pull request, #1:
URL: https://github.com/apache/rocketmq-schema-registry/pull/1

   refer to: https://shimo.im/docs/Ee32MWDG1WFmKRA2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #1: [RIP-42] Support schema registry basic feature

Posted by GitBox <gi...@apache.org>.

MatrixHB commented on PR #1:
URL: https://github.com/apache/rocketmq-schema-registry/pull/1#issuecomment-1181265773

   The REST interface to obtain schema in `SchemaController` is not comprehensive enough. Now we only have `getSchemaBySubject` method, which is `GET /subject/{subject}`
   I think it's necessary to add the following method.
   1、`GET /schema/ids/{id}`
      get schema by a specified schemaID 
   2、`GET /subject/{subject}/schema/versions/{version}`
      get schema by the topic and a given version
   3、`GET /subject/{subject}/schema/versions`
      get all versions of schema by the topic
   4、the existing getSchemaBySubject method can be changed to `GET /subject/{subject}/schema`, which means to get the latest (or binding) schema version of this subject
   
   We can discuss more about the REST interface definition. 
   Open-messaging schema: https://github.com/openmessaging/openschema/blob/master/spec_cn.md
   Confluent schema: [SubjectVersionsResource](https://github.com/confluentinc/schema-registry/blob/master/core/src/main/java/io/confluent/kafka/schemaregistry/rest/resources/SubjectVersionsResource.java#L71)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-schema-registry] duhenglucky merged pull request #1: [RIP-42] Support schema registry basic feature

Posted by GitBox <gi...@apache.org>.

duhenglucky merged PR #1:
URL: https://github.com/apache/rocketmq-schema-registry/pull/1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #1: [RIP-42] Support schema registry basic feature

Posted by GitBox <gi...@apache.org>.

MatrixHB commented on PR #1:
URL: https://github.com/apache/rocketmq-schema-registry/pull/1#issuecomment-1181237910

   ![image](https://user-images.githubusercontent.com/23614576/178393804-033926f3-a59c-4714-b424-7a649c18ca74.png)
   When I evolve the schema, I found the version change but the schemaId is still the same. I think it's better to increase the schemaId while the version evolves, so that when producer send a message with schema, it can guide the consumer to obtain a specified version of schema by passing schemaID.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #1: [RIP-42] Support schema registry basic feature

Posted by GitBox <gi...@apache.org>.

MatrixHB commented on PR #1:
URL: https://github.com/apache/rocketmq-schema-registry/pull/1#issuecomment-1181243004

   ![image](https://user-images.githubusercontent.com/23614576/178394753-e5bc5924-576c-45e9-9802-814dbc16ee18.png)
   When I evolve the schema and the compatibility validation failed, the response is "500, Internal Server Error". It's not suitable because validation error is expectable exception and should have customized new error code.
   Other error, like "Schema is already exist" also have the same problem.
   ![image](https://user-images.githubusercontent.com/23614576/178395464-01960785-e2b0-4c8c-aaef-2672efd1897c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org