You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2016/11/03 13:26:03 UTC

[GitHub] flink pull request #2748: [FLINK-5004] [runtime] Add option to disable query...

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/2748

    [FLINK-5004] [runtime] Add option to disable queryable state

    - By default, the queryable state server is enabled (current behaviour)
    - Via config option `query.server.start` it can be disabled
    - In tests, we disable it by default (see mini cluster change)
    - Migrated config to `QueryableStateOptions`; not part of the TaskManagerOptions as there are also client options available

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 5004-disable_queryable_state

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2748.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2748
    
----
commit 6bac8b1771dd6a4c2241c2902afde6d2fa24679c
Author: Ufuk Celebi <uc...@apache.org>
Date:   2016-11-03T13:08:11Z

    [FLINK-5004] [runtime] Add option to disable queryable state
    
    - By default, the queryable state server is enabled
    - Via config option `query.server.start` it can be disabled
    - In tests, we disable it by default
    - Not part of the TaskManagerOptions as there are also client
      options available

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2748: [FLINK-5004] [runtime] Add option to disable query...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2748


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2748: [FLINK-5004] [runtime] Add option to disable query...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2748#discussion_r86535530
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/query/QueryableStateITCase.java ---
    @@ -115,8 +115,9 @@ public static void setup() {
     			config.setInteger(ConfigConstants.TASK_MANAGER_MEMORY_SIZE_KEY, 4);
     			config.setInteger(ConfigConstants.LOCAL_NUMBER_TASK_MANAGER, NUM_TMS);
     			config.setInteger(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS, NUM_SLOTS_PER_TM);
    -			config.setInteger(ConfigConstants.QUERYABLE_STATE_CLIENT_NETWORK_THREADS, 1);
    -			config.setInteger(ConfigConstants.QUERYABLE_STATE_SERVER_NETWORK_THREADS, 1);
    +			config.setInteger(QueryableStateOptions.CLIENT_NETWORK_THREADS.key(), 1);
    --- End diff --
    
    You can drop the `key()` part and directly use the option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2748: [FLINK-5004] [runtime] Add option to disable query...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2748#discussion_r86535612
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/QueryableStateOptions.java ---
    @@ -0,0 +1,72 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.configuration;
    +
    +import org.apache.flink.annotation.PublicEvolving;
    +
    +import static org.apache.flink.configuration.ConfigOptions.key;
    +
    +/**
    + * The set of configuration options relating to Queryable State.
    + */
    +@PublicEvolving
    +public class QueryableStateOptions {
    +
    +	// ------------------------------------------------------------------------
    +	// Server Options
    +	// ------------------------------------------------------------------------
    +
    +	/** Flag to indicate whether to start the queryable state server. */
    +	public static final ConfigOption<Boolean> START_SERVER =
    +			key("query.server.start").defaultValue(true);
    --- End diff --
    
    I other places, we put the default value on the next line. Assuming more aspects to come (deprecated keys, documentation text), this makes it more readable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2748: [FLINK-5004] [runtime] Add option to disable queryable st...

Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:

    https://github.com/apache/flink/pull/2748
  
    Thanks for review. Renamed it to `enable`, removed the `key` calls and added the line breaks. I also removed the `key` calls in other places where they were not needed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---