[jira] [Commented] (FLINK-9128) Add support for scheduleRunAsync for FencedRpcEndpoints

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425242#comment-16425242 ] 

ASF GitHub Bot commented on FLINK-9128:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5812

    [FLINK-9128] [flip6] Add support for scheduleRunAsync for FencedRpcEndpoints

    ## What is the purpose of the change
    
    Wrap self messages in the FencedRpcEndpoints in a LocalFencedMessage to not drop them
    due to a missing fencing token.
    
    ## Brief change log
     
    - Add `AkkaRpcActor#envelopeSelfMessage` method which can be used to put an envelope around self messages
    
    ## Verifying this change
    
    - Added `AsyncCallsTest#testFencedScheduleWithNoDelay` and `AsyncCallsTest#testFencedScheduleWithDelay`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fencedScheduleRunAsync

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5812.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5812
    
----
commit bb143821f611b268e54ac87b6cda14c259d29077
Author: Till Rohrmann <tr...@...>
Date:   2018-04-03T22:02:52Z

    [FLINK-9128] [flip6] Add support for scheduleRunAsync for FencedRpcEndpoints
    
    Wrap self messages in the FencedRpcEndpoints in a LocalFencedMessage to not drop them
    due to a missing fencing token.

----


> Add support for scheduleRunAsync for FencedRpcEndpoints
> -------------------------------------------------------
>
>                 Key: FLINK-9128
>                 URL: https://issues.apache.org/jira/browse/FLINK-9128
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Critical
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> Currently, the {{FencedRpcEndpoint}} cannot send a {{scheduleRunAsync}} message because it is not properly wrapped in a {{LocalFencedMessage}}. Due to this, the message will be dropped and the code will not be executed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)