You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Niall Pemberton (JIRA)" <ji...@apache.org> on 2007/05/18 16:24:16 UTC
[jira] Created: (BEANUTILS-278) Remove copied Collections classes
Remove copied Collections classes
---------------------------------
Key: BEANUTILS-278
URL: https://issues.apache.org/jira/browse/BEANUTILS-278
Project: Commons BeanUtils
Issue Type: Improvement
Affects Versions: 1.7.0
Reporter: Niall Pemberton
The following 4 Commons Collections classes were copied into BeanUtils so that the dependency on Commons Collections could be removed (these were included in the BeanUtils 1.7.0 release)
ArrayStack.java
Buffer.java
BufferUnderflowException.java
FastHashMap.java
See the following thread for the original reasoning:
http://tinyurl.com/yvma2q
http://tinyurl.com/2hs3hp
Recent discussion thread on this issue is here:
http://tinyurl.com/2vyuk8
Of the above four classes only FastHashMap is used within BeanUtils (and is part of the public API) - not sure why the other classes were included, but it may be because downstream systems such as Struts depend on them (which also removed its Commons Collections when it moved to BeanUtils 1.7.0). Some (but not all) of the BeanUtils public API which exposes FastHashMap was deprecated in the BeanUtils 1.7.0 release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (BEANUTILS-278) Remove copied Collections classes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BEANUTILS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated BEANUTILS-278:
--------------------------------------
Attachment: Beanutils-278.patch
Attaching patch which shows impact of removing FastHashMap from BeanUtils. Not necessarily proposing that this change be applied - but its a good indicator of the impact
> Remove copied Collections classes
> ---------------------------------
>
> Key: BEANUTILS-278
> URL: https://issues.apache.org/jira/browse/BEANUTILS-278
> Project: Commons BeanUtils
> Issue Type: Improvement
> Affects Versions: 1.7.0
> Reporter: Niall Pemberton
> Attachments: Beanutils-278.patch
>
>
> The following 4 Commons Collections classes were copied into BeanUtils so that the dependency on Commons Collections could be removed (these were included in the BeanUtils 1.7.0 release)
> ArrayStack.java
> Buffer.java
> BufferUnderflowException.java
> FastHashMap.java
> See the following thread for the original reasoning:
> http://tinyurl.com/yvma2q
> http://tinyurl.com/2hs3hp
> Recent discussion thread on this issue is here:
> http://tinyurl.com/2vyuk8
> Of the above four classes only FastHashMap is used within BeanUtils (and is part of the public API) - not sure why the other classes were included, but it may be because downstream systems such as Struts depend on them (which also removed its Commons Collections when it moved to BeanUtils 1.7.0). Some (but not all) of the BeanUtils public API which exposes FastHashMap was deprecated in the BeanUtils 1.7.0 release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (BEANUTILS-278) Remove copied Collections classes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BEANUTILS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496945 ]
Niall Pemberton commented on BEANUTILS-278:
-------------------------------------------
Struts 1.2 still has a dependency on FastHashMap - used for the dataSources Map in ActionServlet
> Remove copied Collections classes
> ---------------------------------
>
> Key: BEANUTILS-278
> URL: https://issues.apache.org/jira/browse/BEANUTILS-278
> Project: Commons BeanUtils
> Issue Type: Improvement
> Affects Versions: 1.7.0
> Reporter: Niall Pemberton
> Attachments: Beanutils-278.patch
>
>
> The following 4 Commons Collections classes were copied into BeanUtils so that the dependency on Commons Collections could be removed (these were included in the BeanUtils 1.7.0 release)
> ArrayStack.java
> Buffer.java
> BufferUnderflowException.java
> FastHashMap.java
> See the following thread for the original reasoning:
> http://tinyurl.com/yvma2q
> http://tinyurl.com/2hs3hp
> Recent discussion thread on this issue is here:
> http://tinyurl.com/2vyuk8
> Of the above four classes only FastHashMap is used within BeanUtils (and is part of the public API) - not sure why the other classes were included, but it may be because downstream systems such as Struts depend on them (which also removed its Commons Collections when it moved to BeanUtils 1.7.0). Some (but not all) of the BeanUtils public API which exposes FastHashMap was deprecated in the BeanUtils 1.7.0 release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (BEANUTILS-278) Remove copied Collections classes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BEANUTILS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated BEANUTILS-278:
--------------------------------------
Attachment: Beanutils-278-2.patch
I removed the references to FastHashMap that have no impact on the API (and almost no performance impact IMO) - so that its easier to see where the issue(s) lie
> Remove copied Collections classes
> ---------------------------------
>
> Key: BEANUTILS-278
> URL: https://issues.apache.org/jira/browse/BEANUTILS-278
> Project: Commons BeanUtils
> Issue Type: Improvement
> Affects Versions: 1.7.0
> Reporter: Niall Pemberton
> Attachments: Beanutils-278-2.patch
>
>
> The following 4 Commons Collections classes were copied into BeanUtils so that the dependency on Commons Collections could be removed (these were included in the BeanUtils 1.7.0 release)
> ArrayStack.java
> Buffer.java
> BufferUnderflowException.java
> FastHashMap.java
> See the following thread for the original reasoning:
> http://tinyurl.com/yvma2q
> http://tinyurl.com/2hs3hp
> Recent discussion thread on this issue is here:
> http://tinyurl.com/2vyuk8
> Of the above four classes only FastHashMap is used within BeanUtils (and is part of the public API) - not sure why the other classes were included, but it may be because downstream systems such as Struts depend on them (which also removed its Commons Collections when it moved to BeanUtils 1.7.0). Some (but not all) of the BeanUtils public API which exposes FastHashMap was deprecated in the BeanUtils 1.7.0 release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (BEANUTILS-278) Remove copied Collections classes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BEANUTILS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated BEANUTILS-278:
--------------------------------------
Attachment: (was: Beanutils-278.patch)
> Remove copied Collections classes
> ---------------------------------
>
> Key: BEANUTILS-278
> URL: https://issues.apache.org/jira/browse/BEANUTILS-278
> Project: Commons BeanUtils
> Issue Type: Improvement
> Affects Versions: 1.7.0
> Reporter: Niall Pemberton
> Attachments: Beanutils-278-2.patch
>
>
> The following 4 Commons Collections classes were copied into BeanUtils so that the dependency on Commons Collections could be removed (these were included in the BeanUtils 1.7.0 release)
> ArrayStack.java
> Buffer.java
> BufferUnderflowException.java
> FastHashMap.java
> See the following thread for the original reasoning:
> http://tinyurl.com/yvma2q
> http://tinyurl.com/2hs3hp
> Recent discussion thread on this issue is here:
> http://tinyurl.com/2vyuk8
> Of the above four classes only FastHashMap is used within BeanUtils (and is part of the public API) - not sure why the other classes were included, but it may be because downstream systems such as Struts depend on them (which also removed its Commons Collections when it moved to BeanUtils 1.7.0). Some (but not all) of the BeanUtils public API which exposes FastHashMap was deprecated in the BeanUtils 1.7.0 release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (BEANUTILS-278) Remove copied Collections classes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BEANUTILS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated BEANUTILS-278:
--------------------------------------
Fix Version/s: LATER THAN 1.8.0
> Remove copied Collections classes
> ---------------------------------
>
> Key: BEANUTILS-278
> URL: https://issues.apache.org/jira/browse/BEANUTILS-278
> Project: Commons BeanUtils
> Issue Type: Improvement
> Affects Versions: 1.7.0
> Reporter: Niall Pemberton
> Fix For: LATER THAN 1.8.0
>
> Attachments: Beanutils-278-2.patch
>
>
> The following 4 Commons Collections classes were copied into BeanUtils so that the dependency on Commons Collections could be removed (these were included in the BeanUtils 1.7.0 release)
> ArrayStack.java
> Buffer.java
> BufferUnderflowException.java
> FastHashMap.java
> See the following thread for the original reasoning:
> http://tinyurl.com/yvma2q
> http://tinyurl.com/2hs3hp
> Recent discussion thread on this issue is here:
> http://tinyurl.com/2vyuk8
> Of the above four classes only FastHashMap is used within BeanUtils (and is part of the public API) - not sure why the other classes were included, but it may be because downstream systems such as Struts depend on them (which also removed its Commons Collections when it moved to BeanUtils 1.7.0). Some (but not all) of the BeanUtils public API which exposes FastHashMap was deprecated in the BeanUtils 1.7.0 release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (BEANUTILS-278) Remove copied Collections classes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BEANUTILS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496930 ]
Niall Pemberton commented on BEANUTILS-278:
-------------------------------------------
Commons Digester needs the ArrayStack class (which uses Buffer and BufferUnderflowException) - Struts 1.3 doesn't appear to need any of the classes - except thru' its dependency on Digester
> Remove copied Collections classes
> ---------------------------------
>
> Key: BEANUTILS-278
> URL: https://issues.apache.org/jira/browse/BEANUTILS-278
> Project: Commons BeanUtils
> Issue Type: Improvement
> Affects Versions: 1.7.0
> Reporter: Niall Pemberton
> Attachments: Beanutils-278.patch
>
>
> The following 4 Commons Collections classes were copied into BeanUtils so that the dependency on Commons Collections could be removed (these were included in the BeanUtils 1.7.0 release)
> ArrayStack.java
> Buffer.java
> BufferUnderflowException.java
> FastHashMap.java
> See the following thread for the original reasoning:
> http://tinyurl.com/yvma2q
> http://tinyurl.com/2hs3hp
> Recent discussion thread on this issue is here:
> http://tinyurl.com/2vyuk8
> Of the above four classes only FastHashMap is used within BeanUtils (and is part of the public API) - not sure why the other classes were included, but it may be because downstream systems such as Struts depend on them (which also removed its Commons Collections when it moved to BeanUtils 1.7.0). Some (but not all) of the BeanUtils public API which exposes FastHashMap was deprecated in the BeanUtils 1.7.0 release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org