You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/12/21 11:18:41 UTC
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #844: Show display text instead of name
rhtyd commented on a change in pull request #844:
URL: https://github.com/apache/cloudstack-primate/pull/844#discussion_r546650210
##########
File path: src/views/network/CreateIsolatedNetworkForm.vue
##########
@@ -125,7 +125,7 @@
:placeholder="this.$t('label.networkofferingid')"
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }">
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex">
- {{ opt.name || opt.description }}
+ {{ opt.displaytext || opt.description }}
</a-select-option>
Review comment:
@ravening can this be: `opt.displaytext | opt.name | ...` to cover for the case if/when displaytext is empty?
##########
File path: src/views/network/CreateL2NetworkForm.vue
##########
@@ -125,7 +125,7 @@
:placeholder="this.$t('label.networkofferingid')"
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }">
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex">
- {{ opt.name || opt.description }}
+ {{ opt.displaytext || opt.description }}
Review comment:
@ravening can this be: `opt.displaytext | opt.name | ...` to cover for the case if/when displaytext is empty?
##########
File path: src/views/network/CreateSharedNetworkForm.vue
##########
@@ -284,7 +284,7 @@
:placeholder="this.$t('label.networkofferingid')"
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }">
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex">
- {{ opt.name || opt.description }}
+ {{ opt.displaytext || opt.description }}
Review comment:
@ravening can this be: `opt.displaytext | opt.name | ...` to cover for the case if/when displaytext is empty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org