[GitHub] [incubator-kyuubi] zhouyifan279 commented on a change in pull request #1261: [KYUUBI #1249][DEPS] Do not add hive dependencies in root pom.xml if they are spark's dependencies

[GitBox <gi...@apache.org>]

zhouyifan279 commented on a change in pull request #1261:
URL: https://github.com/apache/incubator-kyuubi/pull/1261#discussion_r734169317



##########
File path: kyuubi-server/pom.xml
##########
@@ -79,22 +80,101 @@
         <dependency>
             <groupId>org.apache.hive</groupId>
             <artifactId>hive-serde</artifactId>
+            <version>${hive.version}</version>
+            <exclusions>
+                <exclusion>
+                    <groupId>*</groupId>
+                    <artifactId>*</artifactId>
+                </exclusion>
+            </exclusions>
         </dependency>
 
         <dependency>
             <groupId>org.apache.hive.shims</groupId>
             <artifactId>hive-shims-common</artifactId>
+            <version>${hive.version}</version>
+            <exclusions>
+                <exclusion>
+                    <groupId>*</groupId>
+                    <artifactId>*</artifactId>
+                </exclusion>
+            </exclusions>
         </dependency>
 
         <dependency>
             <groupId>org.apache.hive.shims</groupId>
             <artifactId>hive-shims-0.23</artifactId>
+            <version>${hive.version}</version>
+            <exclusions>
+                <exclusion>
+                    <groupId>*</groupId>
+                    <artifactId>*</artifactId>
+                </exclusion>
+            </exclusions>
         </dependency>
 
         <dependency>
             <groupId>org.apache.hive</groupId>
             <artifactId>hive-common</artifactId>
+            <version>${hive.version}</version>
+            <!-- Exclude all dependencies but commons-lang:commons-lang as HiveConf needs it -->
             <exclusions>
+                <exclusion>
+                    <groupId>org.apache.hive</groupId>

Review comment:
       Cannot do that because Spark need some of these when running kyuuib-spark-sql-engine tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org